Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When importing, only check for reserved type names when importing a type #31

Closed
wants to merge 1 commit into from

Conversation

DanielRosenwasser
Copy link
Member

Given the following

declare module m {
    module s {}
    export import string = s;
}

we would previously give the error

Import name cannot be 'string'

when string is clearly not in conflict with any declared values.

@JsonFreeman
Copy link
Contributor

👍

@CyrusNajmabadi
Copy link
Contributor

LGTM

@DanielRosenwasser DanielRosenwasser deleted the disallowedNames branch July 16, 2014 21:10
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants