-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include declarationSpan as relevant declaration span when defintion or other places are declaration name #31587
Conversation
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary |
…r other places are declaration name Fixes #30849
5d2653f
to
fd86f40
Compare
…mport export as well
3c77701
to
35c0499
Compare
Rather than all this reverse engineering to find the containing declaration in |
@weswigham it already directly gets the declaration from the declaration of node in |
Ah, OK - |
My preference has been contextSpan so will change to that. Thanks. |
Ping... |
Fixes #72017 Has two fixes: - Hooks up the JS/TS extension to consume the full symbol range provided by microsoft/TypeScript#31587 - Makes the go the definition mouse implementation use the locationLink to compute the preview range. If a`targetSelectionRange` is provided, this means we use the normal `range` to get the preview range
Thanks @sheetalkamat! I've pushed a PR to VS Code to make use of this new property for definitions: microsoft/vscode#75659 You will be able to test this in VS Code insiders once that pr is merged The new API looks good to me, just make sure |
Fixes #30849