Provide full TS symbol range when previewing definitions in VSCode #75659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #72017 Has two fixes: - Hooks up the JS/TS extension to consume the full symbol range provided by microsoft/TypeScript#31587 - Makes the go the definition mouse implementation use the locationLink to compute the preview range. If a`targetSelectionRange` is provided, this means we use the normal `range` to get the preview range
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72017
Has two fixes:
Hooks up the JS/TS extension to consume the full symbol range provided by Include declarationSpan as relevant declaration span when defintion or other places are declaration name TypeScript#31587
Makes the go the definition mouse implementation use the locationLink to compute the preview range. If a
targetSelectionRangeis provided, this means we use the normalrangeto get the preview range. Currently I believe we always use bracket matching