Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build-eslint-rules to npm prepare script #33417

Merged
merged 2 commits into from
Sep 13, 2019

Conversation

andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Sep 13, 2019

My expectation is that my editor should be able to function properly in the TypeScript codebase after npm install && npm run build. This ensures custom eslint rules are built as part of the latter former command to avoid getting this:

MicrosoftTeams-image

Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make it a prepare script rather than part of the main build? Running lint on the command line has building the lint rules as a dep already, and they don't change all that much, so running the build once immediately after install should be fine.

@andrewbranch andrewbranch changed the title Add build-eslint-rules to local build Add build-eslint-rules to npm prepare script Sep 13, 2019
@andrewbranch
Copy link
Member Author

@weswigham that works, done

@andrewbranch andrewbranch merged commit 1755db4 into microsoft:master Sep 13, 2019
@andrewbranch andrewbranch deleted the gulp-eslint branch September 13, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants