Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic file names with project root path #35111

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Nov 14, 2019

Fixes #35094 and #35091

@sheetalkamat
Copy link
Member Author

@typescript-bot cherry-pick this to release-3.7

@sheetalkamat
Copy link
Member Author

@typescript-bot cherry-pick this to release-3.7

@typescript-bot
Copy link
Collaborator

Hey @sheetalkamat, I've opened #35116 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Nov 14, 2019
Component commits:
6945a72 Support dynamic file names with project root path Fixes microsoft#35094
@typescript-bot
Copy link
Collaborator

Hey @sheetalkamat, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.7 manually.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Nov 14, 2019
Component commits:
6945a72 Support dynamic file names with project root path Fixes microsoft#35094

cc30b36 Remove unexpected change
@sheetalkamat sheetalkamat merged commit aa0cb88 into master Nov 14, 2019
@sheetalkamat sheetalkamat deleted the untitled branch November 14, 2019 23:37
sheetalkamat pushed a commit that referenced this pull request Nov 14, 2019
Component commits:
6945a72 Support dynamic file names with project root path Fixes #35094

cc30b36 Remove unexpected change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.7.2] Debug failure: Dynamic files must always have current directory context
4 participants