Include reexported names in list of exported names

[weswigham]

Fixes #38530

[Kingwl]

I‘m not sure what happend... but LGTM...

[weswigham]

Ping @rbuckton ❤️

[rbuckton]

I didn't see any tests affected that use SystemJS, so I'm not sure what effect (if any) this change made. Is it handled by the change in utilities.ts, or are we missing test cases?

[weswigham]

This removed code duplicated the reexports preservation for systemjs. In effect, for systemjs only, we were tracking reexports in a second list. So, rather than duplicating the systemjs code into all the other module systems, I removed code from the systemjs resolver and let it rely on the single list having the reexports in it (since every module mode needs them now).

[rbuckton]

Looks good, assuming we have adequate coverage for system modules, per my other comment.

[weswigham]

@RyanCavanaugh should we backport this change to 3.9?

[ValentinH]

Yes please 🙏😅

[rbuckton]

@weswigham I think you may have missed a test baseline. PR builds are currently failing:

 1) 
       
         unittests:: tsbuild:: inferredTypeFromTransitiveModule::
           tsc --b /src --verbose inferredTypeFromTransitiveModule:: reports errors in files affected by change in signature with isolatedModules serializedEdits
             serializedBuild
               Generates files matching the baseline:
     Error: The baseline file tsbuild/inferredTypeFromTransitiveModule/initial-build/reports-errors-in-files-affected-by-change-in-signature-with-isolatedModules.js has changed.
      at writeComparison (src/harness/harnessIO.ts:1384:23)
      at Object.runBaseline (src/harness/harnessIO.ts:1394:13)
      at Context.<anonymous> (src/testRunner/unittests/tsc/helpers.ts:148:30)
      at processImmediate (internal/timers.js:456:21)

It looks like the diff is due to this change.

[weswigham]

Semantic merge conflicts shakes fist