Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt package-lock.json #40146

Merged
merged 4 commits into from Aug 21, 2020
Merged

Adopt package-lock.json #40146

merged 4 commits into from Aug 21, 2020

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Aug 20, 2020

Add a workflow to update it daily overnight.

@amcasey amcasey requested a review from weswigham August 20, 2020 00:17
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 20, 2020
@amcasey
Copy link
Member Author

amcasey commented Aug 20, 2020

I believe the AzDO pipelines already respect this since they share a task group with the release branches.

@@ -0,0 +1,27 @@
name: Update package-lock.json
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weswigham @andrewbranch Is there a better way to test this than confirming it ran the night after this PR merged?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, but I don’t think any of them are as good as the way you mentioned. You can add a workflow_dispatch trigger in addition to the schedule trigger to be able to run it manually.

.gitignore Outdated Show resolved Hide resolved
@amcasey amcasey merged commit 4eb9fb4 into microsoft:master Aug 21, 2020
@amcasey amcasey deleted the PackageLock branch August 21, 2020 00:50
amcasey added a commit to amcasey/TypeScript that referenced this pull request Sep 22, 2020
DanielRosenwasser pushed a commit that referenced this pull request Jun 15, 2021
DanielRosenwasser added a commit that referenced this pull request Jun 16, 2021
From #40146
From #40703
Fixes #40692

Also

Co-authored-by: Andrew Casey <andrew.casey@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants