Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts #39277 removing bundledPackageName #41499

Merged
merged 4 commits into from Jan 8, 2021

Conversation

orta
Copy link
Contributor

@orta orta commented Nov 11, 2020

Re: #39277 - note that there is #41510 which instead turns this into a suggestion instead of a compiler error.

It's looking like we don't want to ship 4.1 with bundledPackageName included as-is, this PR reverts those changes and tests.

@orta orta self-assigned this Nov 11, 2020
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 11, 2020
@orta orta changed the title Reverts #39277 Reverts #39277 removing bundledPackageName Nov 11, 2020
@weswigham
Copy link
Member

weswigham commented Nov 11, 2020

@orta rather than reverting the whole thing, why not just remove the new error on program construction if the break is too undesirable... (or, better yet, convert it to a suggestion diagnostic somehow rather than removing it outright)? The flag definitely allows you to get better declaration file output.

@orta
Copy link
Contributor Author

orta commented Nov 11, 2020

Yeah, I'm totally open to this instead. Does that work for you @DanielRosenwasser / @RyanCavanaugh?

Will take a fresh stab at that tomorrow 👍🏻

@orta
Copy link
Contributor Author

orta commented Nov 12, 2020

I'll make a PR to release-4.1 cherry-picking either this PR or #41510 when one is merged

@DanielRosenwasser
Copy link
Member

Even if we want to keep the feature, I'm not sold on the name and there isn't much time to bikeshed that.

@typescript-bot cherry-pick this to release-4.1

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 12, 2020

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.1 on this PR at 0c00853. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.1 manually.

@weswigham
Copy link
Member

Even if we want to keep the feature, I'm not sold on the name and there isn't much time to bikeshed that.

Whoa, we've had the flag shipped in the whole beta process - we've already bikeshedded the name. Removing just the error is way less disruptive than stripping the whole feature, and lower risk to the release as a whole.

@sandersn sandersn added this to Not started in PR Backlog Nov 23, 2020
@sandersn
Copy link
Member

@orta Since #41510 is less disruptive, do you want to keep this PR around?

@sandersn sandersn moved this from Not started to Waiting on author in PR Backlog Nov 24, 2020
@orta
Copy link
Contributor Author

orta commented Dec 22, 2020

When this came up in a design meeting, the consensus was still to remove this option, but I'd like to give it one last discussion before dropping completely.

@orta
Copy link
Contributor Author

orta commented Jan 8, 2021

OK, dropping this flag from 4.2 also.

@orta orta merged commit 055f363 into microsoft:master Jan 8, 2021
PR Backlog automation moved this from Waiting on author to Done Jan 8, 2021
Zzzen pushed a commit to Zzzen/TypeScript that referenced this pull request Jan 16, 2021
* Reverts microsoft#39277

* Bring back modeyule resolution for the test runner
@menduz
Copy link

menduz commented Jan 19, 2021

Oh no! Decentraland was really relying on this feature.

Help me with the planning for our tooling: is this completely removed from the plans or it is a temporary thing?

Thanks

@weswigham
Copy link
Member

We have plans to bring it back, but with a different name, and without the error requiring its use - some contention was had that the name bundledPackageName potentially implied that we were some kind of full service bundler, rather than a relatively dumb concatenator.

@arose
Copy link

arose commented Apr 9, 2021

We have plans to bring it back, but with a different name, and without the error requiring its us

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants