New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverts #39277 removing bundledPackageName #41499
Conversation
@orta rather than reverting the whole thing, why not just remove the new error on program construction if the break is too undesirable... (or, better yet, convert it to a suggestion diagnostic somehow rather than removing it outright)? The flag definitely allows you to get better declaration file output. |
Yeah, I'm totally open to this instead. Does that work for you @DanielRosenwasser / @RyanCavanaugh? Will take a fresh stab at that tomorrow 👍🏻 |
I'll make a PR to release-4.1 cherry-picking either this PR or #41510 when one is merged |
Even if we want to keep the feature, I'm not sold on the name and there isn't much time to bikeshed that. @typescript-bot cherry-pick this to release-4.1 |
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.1 manually. |
Whoa, we've had the flag shipped in the whole beta process - we've already bikeshedded the name. Removing just the error is way less disruptive than stripping the whole feature, and lower risk to the release as a whole. |
When this came up in a design meeting, the consensus was still to remove this option, but I'd like to give it one last discussion before dropping completely. |
bc0fc4a
to
8207911
Compare
OK, dropping this flag from 4.2 also. |
* Reverts microsoft#39277 * Bring back modeyule resolution for the test runner
Oh no! Decentraland was really relying on this feature. Help me with the planning for our tooling: is this completely removed from the plans or it is a temporary thing? Thanks |
We have plans to bring it back, but with a different name, and without the error requiring its use - some contention was had that the name |
Any update on this? |
Re: #39277 - note that there is #41510 which instead turns this into a suggestion instead of a compiler error.
It's looking like we don't want to ship 4.1 with
bundledPackageName
included as-is, this PR reverts those changes and tests.