Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default tsc --init to es2016 #45934

Merged
merged 1 commit into from Sep 24, 2021
Merged

Default tsc --init to es2016 #45934

merged 1 commit into from Sep 24, 2021

Conversation

orta
Copy link
Contributor

@orta orta commented Sep 17, 2021

ES5 is a pretty low target, I doubt most folks making a new TypeScript project want something that old.

So, I propose we think of the default target in --init as being "5 years" ago, and generally try to keep that in sync. E.g. sometime next year we'd accept a PR which sets it to be es2017.

@orta orta self-assigned this Sep 17, 2021
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 17, 2021
@AviVahl
Copy link

AviVahl commented Sep 18, 2021

Worth noting that "dom" lib was included by default when target was set to "es5" (because "lib" is commented out in tsc --init template). May no longer be the case with this change.

@DanielRosenwasser
Copy link
Member

I would hope that dom isn't excluded as a result of target - that would be a confusing upgrade step. 😬

@orta
Copy link
Contributor Author

orta commented Sep 24, 2021

This got OK'd at a design meeting 👍🏻

@orta orta merged commit 12003e5 into microsoft:main Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants