Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(46589): Extra ? added to method in method signature completion for optional method #46594

Merged
merged 1 commit into from Nov 3, 2021

Conversation

@a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Oct 29, 2021

Fixes #46589

@a-tarasyuk a-tarasyuk marked this pull request as draft Oct 29, 2021
@a-tarasyuk a-tarasyuk force-pushed the fix/46589 branch 2 times, most recently from 6bb521f to b1f2db7 Oct 29, 2021
@a-tarasyuk a-tarasyuk marked this pull request as ready for review Oct 29, 2021
Copy link
Member

@andrewbranch andrewbranch left a comment

🌟 Thanks!

@andrewbranch andrewbranch requested a review from gabritto Oct 29, 2021
Copy link
Member

@gabritto gabritto left a comment

We shouldn't get rid of optional altogether in the codefix helper function, I think that is why there are tests failing on CI. Left a comment with possible solutions.

src/services/codefixes/helpers.ts Outdated Show resolved Hide resolved
@a-tarasyuk a-tarasyuk requested a review from gabritto Oct 30, 2021
@andrewbranch andrewbranch added this to the TypeScript 4.5.2 milestone Nov 1, 2021
Copy link
Member

@gabritto gabritto left a comment

I think this is closer to being what we want, just left a comment for one case left to consider. Thanks :)

src/services/completions.ts Outdated Show resolved Hide resolved
Copy link
Member

@gabritto gabritto left a comment

Left a comment for a typo, but I think other than that we're good to go now. Thanks!

src/services/codefixes/helpers.ts Outdated Show resolved Hide resolved
@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Nov 3, 2021

@typescript-bot cherry-pick this to release-4.5

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Nov 3, 2021

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.5 on this PR at cd33fc8. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Nov 3, 2021

Hey @andrewbranch, I've opened #46667 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this issue Nov 3, 2021
Component commits:
cd33fc8 fix(46589): omit ? in method signature completion for optional methods
@andrewbranch andrewbranch merged commit 7264cf7 into microsoft:main Nov 3, 2021
10 checks passed
DanielRosenwasser pushed a commit that referenced this issue Nov 3, 2021
Component commits:
cd33fc8 fix(46589): omit ? in method signature completion for optional methods

Co-authored-by: Oleksandr T <oleksandr.tarasiuk@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants