Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove abort from the abort signal #47507

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Remove abort from the abort signal #47507

merged 1 commit into from
Jan 19, 2022

Conversation

orta
Copy link
Contributor

@orta orta commented Jan 19, 2022

This code clashes with the abort signal in node's dts, making it not possible to have both DOM and node in the same project:

../node/globals.d.ts(72,13): error TS2403: Subsequent variable declarations must have the same type. Variable 'AbortSignal' must be of type '{ new (): AbortSignal; prototype: AbortSignal; abort(reason?: any): AbortSignal; }', but here has type '{ new (): AbortSignal; prototype: AbortSignal; }'.

Logs

The automation during the deploy process to this repo should ave persisted the comment, but didn't because of the new reason param

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 19, 2022
@orta
Copy link
Contributor Author

orta commented Jan 19, 2022

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 19, 2022

Heya @orta, I've started to run the parallelized Definitely Typed test suite on this PR at 6d96348. You can monitor the build here.

@orta
Copy link
Contributor Author

orta commented Jan 19, 2022

DT results look mundanely correct 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants