Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary check in getNarrowableTypeForReference #47953

Merged
merged 2 commits into from Feb 18, 2022
Merged

Conversation

ahejlsberg
Copy link
Member

@ahejlsberg ahejlsberg commented Feb 18, 2022

Fixes #47890.

@ahejlsberg
Copy link
Member Author

@ahejlsberg ahejlsberg commented Feb 18, 2022

@RyanCavanaugh @DanielRosenwasser We'll want to cherry pick this one.

@RyanCavanaugh
Copy link
Member

@RyanCavanaugh RyanCavanaugh commented Feb 18, 2022

@typescript-bot cherry-pick this to release-4.6

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Feb 18, 2022

Heya @RyanCavanaugh, I've started to run the task to cherry-pick this into release-4.6 on this PR at f4dcf88. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Feb 18, 2022

Hey @RyanCavanaugh, I've opened #47957 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this issue Feb 18, 2022
Component commits:
aa1c25d Remove unnecessary check in getNarrowableTypeForReference

f4dcf88 Add regression test
@ahejlsberg ahejlsberg merged commit db226a8 into main Feb 18, 2022
11 checks passed
@ahejlsberg ahejlsberg deleted the fix47890 branch Feb 18, 2022
DanielRosenwasser pushed a commit that referenced this issue Feb 19, 2022
Component commits:
aa1c25d Remove unnecessary check in getNarrowableTypeForReference

f4dcf88 Add regression test

Co-authored-by: Anders Hejlsberg <andersh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants