Allow indirect calls #51989
Merged
Allow indirect calls #51989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The TypeScript team hasn't accepted the linked issue #35866. If you can get it accepted, this PR will have a better chance of being reviewed. |
|
It's possible that restricting the LHS to only allow exactly |
|
@microsoft-github-policy-service agree |
sandersn
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is revived from #35878 ("No error on indirect calls"), which stalled out and was closed earlier this year as stale.
Fixes: #35866.
Per @RyanCavanaugh's comment on duplicate issue #48163, I've changed the check to explicitly require
0,rather than arbitrary expressions on the left of the comma. To address the unresponded comment on the earlier PR, I left the check for either an access expression or exactlyevalfor the RHS, since these are the only two cases where an indirect call is actually different from a direct call (to my knowledge).