Defer conditional types with multi-element tuple types in `extends` clause #52091

ahejlsberg · 2023-01-04T00:59:21Z

Fixes #52068.

ahejlsberg · 2023-01-04T00:59:55Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2023-01-04T00:59:58Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at e9f81ce. You can monitor the build here.

typescript-bot · 2023-01-04T00:59:59Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at e9f81ce. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-04T00:59:59Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at e9f81ce. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-04T00:59:59Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at e9f81ce. You can monitor the build here.

typescript-bot · 2023-01-04T00:59:59Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at e9f81ce. You can monitor the build here.

typescript-bot · 2023-01-04T01:13:50Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/52091/merge:

Everything looks good!

typescript-bot · 2023-01-04T01:15:06Z

Heya @ahejlsberg, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

typescript-bot · 2023-01-04T01:16:20Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52091

_Metric	_main	₅₂₀₉₁	_Delta	_Best	_Worst
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{371,830k (± 0.01%)}	_{371,857k (± 0.01%)}	_{+27k (+ 0.01%)}	_371,793k	_371,900k
_{Parse Time}	_{4.16s (± 0.72%)}	_{4.14s (± 0.41%)}	_{-0.02s (- 0.55%)}	_4.12s	_4.16s
_{Bind Time}	_{1.27s (± 0.39%)}	_{1.27s (± 0.63%)}	_{-0.00s (- 0.07%)}	_1.26s	_1.28s
_{Check Time}	_{9.32s (± 0.64%)}	_{9.29s (± 0.68%)}	_{-0.03s (- 0.33%)}	_9.23s	_9.41s
_{Emit Time}	_{8.00s (± 0.64%)}	_{7.98s (± 0.35%)}	_{-0.03s (- 0.32%)}	_7.95s	_8.02s
_{Total Time}	_{22.76s (± 0.42%)}	_{22.68s (± 0.39%)}	_{-0.08s (- 0.36%)}	_22.57s	_22.82s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{199,864k (± 0.03%)}	_{200,353k (± 0.69%)}	_{+489k (+ 0.24%)}	_199,422k	_203,132k
_{Parse Time}	_{1.80s (± 0.74%)}	_{1.82s (± 0.56%)}	_{+0.02s (+ 0.91%)}	_1.80s	_1.83s
_{Bind Time}	_{0.84s (± 0.54%)}	_{0.84s (± 0.74%)}	_{-0.00s (- 0.40%)}	_0.83s	_0.85s
_{Check Time}	_{10.05s (± 0.87%)}	_{10.15s (± 0.86%)}	_{+0.10s (+ 1.02%)}	_10.00s	_10.23s
_{Emit Time}	_{2.99s (± 1.96%)}	_{3.04s (± 4.86%)}	_{+0.05s (+ 1.58%)}	_2.94s	_3.34s
_{Total Time}	_{15.68s (± 0.77%)}	_{15.85s (± 1.21%)}	_{+0.17s (+ 1.06%)}	_15.66s	_16.20s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{353,272k (± 0.01%)}	_{353,277k (± 0.01%)}	_{+5k (+ 0.00%)}	_353,239k	_353,347k
_{Parse Time}	_{3.18s (± 0.84%)}	_{3.17s (± 0.43%)}	_{-0.00s (- 0.08%)}	_3.16s	_3.19s
_{Bind Time}	_{1.12s (± 0.88%)}	_{1.11s (± 1.07%)}	_{-0.01s (- 1.32%)}	_1.10s	_1.13s
_{Check Time}	_{7.87s (± 0.66%)}	_{7.84s (± 0.56%)}	_{-0.03s (- 0.37%)}	_7.79s	_7.90s
_{Emit Time}	_{4.49s (± 0.69%)}	_{4.46s (± 0.28%)}	_{-0.03s (- 0.58%)}	_4.45s	_4.48s
_{Total Time}	_{16.66s (± 0.54%)}	_{16.58s (± 0.24%)}	_{-0.08s (- 0.45%)}	_16.51s	_16.63s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{309,221k (± 0.00%)}	_{309,214k (± 0.00%)}	_{-7k (- 0.00%)}	_309,203k	_309,238k
_{Parse Time}	_{2.57s (± 2.25%)}	_{2.63s (± 1.96%)}	_{+0.06s (+ 2.29%)}	_2.58s	_2.72s
_{Bind Time}	_{1.09s (± 7.67%)}	_{1.07s (± 1.25%)}	_{-0.02s (- 1.92%)}	_1.05s	_1.09s
_{Check Time}	_{7.41s (± 0.54%)}	_{7.38s (± 0.64%)}	_{-0.03s (- 0.35%)}	_7.31s	_7.45s
_{Emit Time}	_{4.22s (± 0.53%)}	_{4.23s (± 0.77%)}	_{+0.01s (+ 0.29%)}	_4.19s	_4.27s
_{Total Time}	_{15.28s (± 0.32%)}	_{15.31s (± 0.38%)}	_{+0.02s (+ 0.16%)}	_15.26s	_15.42s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{484,359k (± 0.00%)}	_{484,356k (± 0.01%)}	_{-3k (- 0.00%)}	_484,318k	_484,395k
_{Parse Time}	_{3.68s (± 0.46%)}	_{3.67s (± 0.44%)}	_{-0.00s (- 0.13%)}	_3.66s	_3.70s
_{Bind Time}	_{1.01s (± 1.00%)}	_{1.01s (± 0.54%)}	_{-0.01s (- 0.59%)}	_1.00s	_1.01s
_{Check Time}	_{17.96s (± 0.82%)}	_{17.91s (± 0.66%)}	_{-0.05s (- 0.28%)}	_17.79s	_18.14s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{22.66s (± 0.73%)}	_{22.59s (± 0.54%)}	_{-0.06s (- 0.27%)}	_22.45s	_22.81s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{567,302k (± 0.00%)}	_{567,330k (± 0.01%)}	_{+28k (+ 0.00%)}	_567,295k	_567,439k
_{Parse Time}	_{4.74s (± 0.62%)}	_{4.77s (± 0.47%)}	_{+0.03s (+ 0.59%)}	_4.75s	_4.80s
_{Bind Time}	_{1.64s (± 0.47%)}	_{1.66s (± 0.59%)}	_{+0.01s (+ 0.87%)}	_1.65s	_1.67s
_{Check Time}	_{2.83s (± 0.36%)}	_{2.84s (± 0.28%)}	_{+0.01s (+ 0.18%)}	_2.83s	_2.84s
_{Emit Time}	_{0.08s (± 6.58%)}	_{0.09s (± 6.05%)}	_{+0.00s (+ 2.03%)}	_0.08s	_0.09s
_{Total Time}	_{9.31s (± 0.38%)}	_{9.35s (± 0.33%)}	_{+0.05s (+ 0.53%)}	_9.32s	_9.40s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₀₉₁	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

… types as of TS4.9, conditional types are only deferred for single-element tuples, not multi-element ones. this should be fixed in microsoft/TypeScript#52091, slated for the TS5.0 milestone. until then, however, the implementations of `MutuallyAssignable`, `And`, and `Xor` can be assumed to be bugged. this commit fixes them to properly defer types. `Or` was also like this but fixed in earlier commit 0cd75d4

weswigham

We don't want to think of a way to expand this to cover, eg {x: X} extends {x: Y} and similar ilk, right?

ahejlsberg · 2023-01-05T22:24:28Z

@weswigham Would be nice to do so, but requires more thinking about permissive/restrictive instantiations and/or some sort of "possibly assignable to" relation. I'm chewing on that, but nothing concrete yet.

ahejlsberg added 2 commits January 3, 2023 16:47

Defer conditional types with multi-element tuple types in extends clause

513ef34

Add tests

e9f81ce

typescript-bot assigned ahejlsberg Jan 4, 2023

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jan 4, 2023

ahejlsberg requested review from RyanCavanaugh and weswigham January 4, 2023 01:06

Andarist mentioned this pull request Jan 4, 2023

Add an extra test case for deferred conditional types #52094

Closed

weswigham approved these changes Jan 5, 2023

View reviewed changes

RyanCavanaugh approved these changes Jan 5, 2023

View reviewed changes

Add more tests

7cc1521

ahejlsberg merged commit 400e2c2 into main Jan 6, 2023

ahejlsberg deleted the fix52068 branch January 6, 2023 17:18

Andarist mentioned this pull request Mar 18, 2023

never doesn't equal never when never is keys/values from filtering generic object wrapped inside another object by exact value #51145

Open

Andarist mentioned this pull request Oct 31, 2023

Adding parentheses changes the result of type inference #56270

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Defer conditional types with multi-element tuple types in `extends` clause #52091

Defer conditional types with multi-element tuple types in `extends` clause #52091

ahejlsberg commented Jan 4, 2023

ahejlsberg commented Jan 4, 2023

typescript-bot commented Jan 4, 2023 •

edited

Loading

typescript-bot commented Jan 4, 2023 •

edited

Loading

typescript-bot commented Jan 4, 2023 •

edited

Loading

typescript-bot commented Jan 4, 2023 •

edited

Loading

typescript-bot commented Jan 4, 2023 •

edited

Loading

typescript-bot commented Jan 4, 2023

typescript-bot commented Jan 4, 2023

typescript-bot commented Jan 4, 2023

weswigham left a comment

ahejlsberg commented Jan 5, 2023

Defer conditional types with multi-element tuple types in extends clause #52091

Defer conditional types with multi-element tuple types in extends clause #52091

Conversation

ahejlsberg commented Jan 4, 2023

ahejlsberg commented Jan 4, 2023

typescript-bot commented Jan 4, 2023 • edited Loading

typescript-bot commented Jan 4, 2023 • edited Loading

typescript-bot commented Jan 4, 2023 • edited Loading

typescript-bot commented Jan 4, 2023 • edited Loading

typescript-bot commented Jan 4, 2023 • edited Loading

typescript-bot commented Jan 4, 2023

typescript-bot commented Jan 4, 2023

typescript-bot commented Jan 4, 2023

weswigham left a comment

Choose a reason for hiding this comment

ahejlsberg commented Jan 5, 2023

Defer conditional types with multi-element tuple types in `extends` clause #52091

Defer conditional types with multi-element tuple types in `extends` clause #52091

typescript-bot commented Jan 4, 2023 •

edited

Loading

typescript-bot commented Jan 4, 2023 •

edited

Loading

typescript-bot commented Jan 4, 2023 •

edited

Loading

typescript-bot commented Jan 4, 2023 •

edited

Loading

typescript-bot commented Jan 4, 2023 •

edited

Loading