Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing reference in js (#50509) #53000

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Fix missing reference in js (#50509) #53000

merged 1 commit into from
Mar 17, 2023

Conversation

gulewei
Copy link
Contributor

@gulewei gulewei commented Feb 27, 2023

Fixes #50509
Binder binds a special symbol for BinaryExpression in a JavaScript file, which Checker then finds when searching for references to the BinaryExpression's lhs. However, lhs should have its own symbol when it is a property access for the 'this' keyword and has a contextual type.

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 27, 2023
@gulewei
Copy link
Contributor Author

gulewei commented Feb 27, 2023

@microsoft-github-policy-service agree

@sandersn sandersn added this to Not started in PR Backlog Mar 9, 2023
@sandersn sandersn self-assigned this Mar 9, 2023
@sandersn sandersn moved this from Not started to Waiting on reviewers in PR Backlog Mar 9, 2023
PR Backlog automation moved this from Waiting on reviewers to Needs merge Mar 17, 2023
@sandersn sandersn merged commit bf369f1 into microsoft:main Mar 17, 2023
PR Backlog automation moved this from Needs merge to Done Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
Archived in project
PR Backlog
  
Done
Development

Successfully merging this pull request may close these issues.

missing reference when assignment on property of contextual this
3 participants