Additional fix to issue #50509 #54423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
sandersn
requested changes
Jun 5, 2023
sandersn
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an additional fix to issue #50509. The issue has been closed by my previous PR #53000, but there is still an unexpected case left over.
I need to check if there is a
ThisType<T>forthiskeyword in its contextual type. I was getting it's containing object literal then to callgetApparentTypeOfContextualTypeandgetThisTypeArgumentto see what I got, but didn't know I need continue looking in any directly enclosing object literals. I found this already been took care of by some code ingetContextualThisParameterType, so I move them into a new functiongetThisTypeOfObjectLiteralFromContextualTypefor reuse.Sorry for have to fix the issue in twice.