-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform namespaces declared with module keyword to namespace keyword in d.ts files #54134
Merged
rbuckton
merged 8 commits into
microsoft:main
from
bloomberg:CC972/deprecate-namespaces-declared-with-module-keyword
Jun 26, 2023
Merged
Transform namespaces declared with module keyword to namespace keyword in d.ts files #54134
rbuckton
merged 8 commits into
microsoft:main
from
bloomberg:CC972/deprecate-namespaces-declared-with-module-keyword
Jun 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chi Leung <chiguan.leung@gmail.com>
Signed-off-by: Chi Leung <chiguan.leung@gmail.com>
Signed-off-by: Chi Leung <chiguan.leung@gmail.com>
Signed-off-by: Chi Leung <chiguan.leung@gmail.com>
…ith-module-keyword Transform namespaces declared with module keyword to namespace keyword in d.ts files
The TypeScript team hasn't accepted the linked issue #51825. If you can get it accepted, this PR will have a better chance of being reviewed. |
sandersn
reviewed
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This issue doesn't fix all of Consider deprecating namespaces declared with the
module
keyword #51825, so I'd recommend swapping the wording to "Addresses part of Consider deprecating namespaces declared with themodule
keyword #51825" so that github doesn't close the original issue. - The implementation seems straightforward and the test changes look right to me, but @rbuckton should probably sign off on the API change.
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
rbuckton
requested changes
Jun 8, 2023
rbuckton
requested changes
Jun 23, 2023
rbuckton
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #51825.
With this PR, we encourage people to move away from declaring namespaces with the
module
keyword.Currently, if we have
foo.ts
:module foo {}
This leads to the following
foo.d.ts
file:declare module foo {}
This PR changes the declaration emit to transform
module
tonamespace
:declare namespace foo {}
"Ambient module declarations", such as the below, will be unaffected:
declare module "bar" {}