ImportAttributes should go through the same emit phases when in an ImportTypeNode #56395
Conversation
typescript-bot
added
the
For Uncommitted Bug
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
…y are part of an ImportTypeNode.
dragomirtitian
force-pushed
the
emit-import-attributes-bug
branch
from
53db3dd
to
a61b9ae
Compare
typescript-bot
added
For Backlog Bug
| Unspecified, // Emitting an otherwise unspecified node | ||
| EmbeddedStatement, // Emitting an embedded statement | ||
| JsxAttributeValue, // Emitting a JSX attribute value | ||
| ImportTypeNodeAttributes,// Emitting attributes as part of an ImportTypeNode |
There was a problem hiding this comment.
Not sure how much this matters given we seem to be adding stuff here, I do wonder if new things should be marked as internal. @rbuckton probably knows better than me for this bit.
There was a problem hiding this comment.
I think it's fine for this to be public, as it is observable to custom transformers.
|
@jakebailey This one would also ideally make it in before isolated declarations. It causes a failure in a test. Not critical but nice to have. |
| Unspecified, // Emitting an otherwise unspecified node | ||
| EmbeddedStatement, // Emitting an embedded statement | ||
| JsxAttributeValue, // Emitting a JSX attribute value | ||
| ImportTypeNodeAttributes,// Emitting attributes as part of an ImportTypeNode |
There was a problem hiding this comment.
I think it's fine for this to be public, as it is observable to custom transformers.
Fixes #56394