Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make our dts files compile when exactOptionalPropertyTypes is enabled downstream #56489

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

jakebailey
Copy link
Member

Fixes #56478

The JSDoc one is the only one that appears in our public API, but it wasn't too hard to make our internal API also pass too.

One day, maybe we should enable exactOptionalPropertyTypes ourselves.

@typescript-bot
Copy link
Collaborator

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@jakebailey jakebailey merged commit 0aa2c48 into microsoft:main Nov 21, 2023
19 checks passed
typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Nov 21, 2023
@jakebailey jakebailey deleted the fix-56478 branch February 23, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5.3] Type error in typescript.d.ts with exactOptionalPropertyTypes = true
3 participants