Dom update 2024-01-11 #57027
Merged
Dom update 2024-01-11 #57027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from microsoft/typescript-dom-lib-generator
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@typescript-bot test top100 |
|
Heya @sandersn, I've started to run the diff-based user code test suite on this PR at 3bae7b9. You can monitor the build here. Update: The results are in! |
|
Heya @sandersn, I've started to run the regular perf test suite on this PR at 3bae7b9. You can monitor the build here. Update: The results are in! |
|
Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at 3bae7b9. You can monitor the build here. Update: The results are in! |
|
Heya @sandersn, I've started to run the diff-based top-repos suite on this PR at 3bae7b9. You can monitor the build here. Update: The results are in! |
|
Hey @sandersn, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
|
@sandersn Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
|
Hey @sandersn, the results of running the DT tests are ready. Branch only errors:Package: webrtc |
|
@sandersn Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Details
|
|
@sandersn Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
startupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
@sandersn Any insight as to why these have been deleted? Looking at the documentation on mdn these properties should exist: https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerRegistration/showNotification |
|
It was based on microsoft/TypeScript-DOM-lib-generator#1631, which updates the types to @webref/idl@3.39.1 and browser-compat-data@5.3.21 The comments on that PR says that NotificationOptions is Blink-only as of 2023-10. |
Comment on lines
-1003
to
1013
| interface NotificationAction { | ||
| action: string; | ||
| icon?: string; | ||
| title: string; | ||
| } | ||
|
|
||
| interface NotificationOptions { | ||
| actions?: NotificationAction[]; | ||
| badge?: string; | ||
| body?: string; | ||
| data?: any; | ||
| dir?: NotificationDirection; | ||
| icon?: string; | ||
| image?: string; | ||
| lang?: string; | ||
| renotify?: boolean; | ||
| requireInteraction?: boolean; | ||
| silent?: boolean | null; | ||
| tag?: string; | ||
| timestamp?: EpochTimeStamp; | ||
| vibrate?: VibratePattern; | ||
| } |
There was a problem hiding this comment.
Why were those properties removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not many breaks from this one. Two packages have their shims break and one package assigns to a property that's not there anymore (but might still be on the browser it targets?)
Performance:
Failures:
Summary of changes:
Credential, justvoid