Properly handle non-generic string mapping types in unions and intersections #57197

ahejlsberg · 2024-01-27T01:20:15Z

…ections

ahejlsberg · 2024-01-27T01:21:11Z

@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2024-01-27T01:21:13Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at f445b4f. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-27T01:21:13Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at f445b4f. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-27T01:21:13Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at f445b4f. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-27T01:21:13Z

Heya @ahejlsberg, I've started to run the faster perf test suite on this PR at f445b4f. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-27T01:45:03Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/57197/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2024-01-27T01:50:52Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,659k (± 0.01%)}	_{295,646k (± 0.01%)}	_~	_295,631k	_295,674k	_{p=0.468 n=6}
_{Parse Time}	_{2.66s (± 0.34%)}	_{2.66s (± 0.55%)}	_~	_2.64s	_2.68s	_{p=0.804 n=6}
_{Bind Time}	_{0.83s (± 1.18%)}	_{0.83s (± 1.52%)}	_~	_0.82s	_0.85s	_{p=0.799 n=6}
_{Check Time}	_{8.19s (± 0.24%)}	_{8.20s (± 0.19%)}	_~	_8.17s	_8.21s	_{p=0.566 n=6}
_{Emit Time}	_{7.10s (± 0.35%)}	_{7.09s (± 0.47%)}	_~	_7.06s	_7.14s	_{p=0.518 n=6}
_{Total Time}	_{18.79s (± 0.09%)}	_{18.78s (± 0.26%)}	_~	_18.74s	_18.85s	_{p=0.572 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,935k (± 1.25%)}	_{191,536k (± 0.02%)}	_~	_191,490k	_191,576k	_{p=0.689 n=6}
_{Parse Time}	_{1.36s (± 1.21%)}	_{1.35s (± 1.36%)}	_~	_1.33s	_1.37s	_{p=0.935 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.34s (± 0.38%)}	_{9.35s (± 0.43%)}	_~	_9.29s	_9.40s	_{p=0.809 n=6}
_{Emit Time}	_{2.63s (± 0.63%)}	_{2.61s (± 0.82%)}	_~	_2.58s	_2.64s	_{p=0.169 n=6}
_{Total Time}	_{14.04s (± 0.16%)}	_{14.03s (± 0.22%)}	_~	_13.99s	_14.07s	_{p=0.871 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,460k (± 0.01%)}	_{347,458k (± 0.00%)}	_~	_347,443k	_347,477k	_{p=0.936 n=6}
_{Parse Time}	_{2.48s (± 0.54%)}	_{2.47s (± 0.21%)}	_~	_2.46s	_2.47s	_{p=0.140 n=6}
_{Bind Time}	_{0.92s (± 0.56%)}	_{0.92s (± 0.59%)}	_~	_0.92s	_0.93s	_{p=0.640 n=6}
_{Check Time}	_{6.93s (± 0.43%)}	_{6.94s (± 0.40%)}	_~	_6.91s	_6.97s	_{p=0.672 n=6}
_{Emit Time}	_{4.05s (± 0.33%)}	_{4.06s (± 0.52%)}	_~	_4.04s	_4.10s	_{p=0.676 n=6}
_{Total Time}	_{14.38s (± 0.24%)}	_{14.40s (± 0.21%)}	_~	_14.35s	_14.43s	_{p=0.745 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,839k (± 0.00%)}	_{302,840k (± 0.01%)}	_~	_302,803k	_302,881k	_{p=0.936 n=6}
_{Parse Time}	_{2.01s (± 1.04%)}	_{2.01s (± 0.68%)}	_~	_1.99s	_2.02s	_{p=0.934 n=6}
_{Bind Time}	_{1.01s (± 1.02%)}	_{1.00s (± 1.09%)}	_~	_0.99s	_1.02s	_{p=0.241 n=6}
_{Check Time}	_{6.32s (± 0.31%)}	_{6.33s (± 0.37%)}	_~	_6.30s	_6.36s	_{p=0.464 n=6}
_{Emit Time}	_{3.59s (± 0.25%)}	_{3.60s (± 0.57%)}	_~	_3.57s	_3.62s	_{p=0.682 n=6}
_{Total Time}	_{12.93s (± 0.36%)}	_{12.94s (± 0.17%)}	_~	_12.90s	_12.96s	_{p=0.570 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,320k (± 0.00%)}	_{511,321k (± 0.01%)}	_~	_511,286k	_511,380k	_{p=0.748 n=6}
_{Parse Time}	_{2.65s (± 0.69%)}	_{2.66s (± 0.24%)}	_~	_2.65s	_2.67s	_{p=0.295 n=6}
_{Bind Time}	_{0.99s (± 0.41%)}	_{1.00s (± 1.26%)}	_~	_0.98s	_1.02s	_{p=0.101 n=6}
_{Check Time}	_{17.23s (± 0.31%)}	_{17.24s (± 0.22%)}	_~	_17.20s	_17.30s	_{p=0.630 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.87s (± 0.33%)}	_{20.90s (± 0.19%)}	_~	_20.86s	_20.96s	_{p=0.469 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,694,776k (± 0.00%)}	_{1,694,756k (± 0.00%)}	_~	_1,694,725k	_1,694,811k	_{p=0.173 n=6}
_{Parse Time}	_{6.53s (± 0.23%)}	_{6.53s (± 0.38%)}	_~	_6.49s	_6.56s	_{p=0.935 n=6}
_{Bind Time}	_{2.36s (± 0.56%)}	_{2.30s (± 6.60%)}	_~	_1.99s	_2.37s	_{p=0.804 n=6}
_{Check Time}	_{55.27s (± 0.60%)}	_{55.06s (± 0.34%)}	_~	_54.75s	_55.33s	_{p=0.297 n=6}
_{Emit Time}	_{0.16s (± 3.16%)}	_{0.16s (± 0.00%)}	_~	_0.16s	_0.16s	_{p=0.174 n=6}
_{Total Time}	_{64.32s (± 0.54%)}	_{64.05s (± 0.37%)}	_~	_63.75s	_64.40s	_{p=0.173 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,413,033k (± 0.03%)}	_{2,412,993k (± 0.02%)}	_~	_2,412,432k	_2,413,796k	_{p=1.000 n=6}
_{Parse Time}	_{4.94s (± 1.32%)}	_{4.91s (± 0.66%)}	_~	_4.87s	_4.95s	_{p=0.378 n=6}
_{Bind Time}	_{1.89s (± 0.93%)}	_{1.87s (± 0.87%)}	_~	_1.85s	_1.89s	_{p=0.279 n=6}
_{Check Time}	_{33.41s (± 0.22%)}	_{33.42s (± 0.23%)}	_~	_33.35s	_33.55s	_{p=0.747 n=6}
_{Emit Time}	_{2.67s (± 1.02%)}	_{2.68s (± 1.26%)}	_~	_2.65s	_2.74s	_{p=0.748 n=6}
_{Total Time}	_{42.93s (± 0.14%)}	_{42.92s (± 0.20%)}	_~	_42.84s	_43.04s	_{p=0.471 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{419,755k (± 0.01%)}	_{419,753k (± 0.01%)}	_~	_419,716k	_419,789k	_{p=1.000 n=6}
_{Parse Time}	_{2.71s (± 2.87%)}	_{2.73s (± 2.96%)}	_~	_2.66s	_2.84s	_{p=0.406 n=6}
_{Bind Time}	_{1.17s (± 6.11%)}	_{1.17s (± 6.41%)}	_~	_1.07s	_1.23s	_{p=1.000 n=6}
_{Check Time}	_{15.12s (± 0.32%)}	_{15.13s (± 0.28%)}	_~	_15.09s	_15.19s	_{p=0.629 n=6}
_{Emit Time}	_{1.14s (± 1.29%)}	_{1.15s (± 0.65%)}	_~	_1.14s	_1.16s	_{p=0.300 n=6}
_{Total Time}	_{20.14s (± 0.25%)}	_{20.18s (± 0.23%)}	_~	_20.13s	_20.25s	_{p=0.199 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,808,667k (± 0.00%)}	_{2,808,716k (± 0.00%)}	_{+49k (+ 0.00%)}	_2,808,663k	_2,808,762k	_{p=0.013 n=6}
_{Parse Time}	_{10.63s (± 0.41%)}	_{10.64s (± 0.38%)}	_~	_10.60s	_10.71s	_{p=1.000 n=6}
_{Bind Time}	_{3.39s (± 0.15%)}	_{3.42s (± 0.75%)}	_{+0.03s (+ 0.89%)}	_3.39s	_3.46s	_{p=0.020 n=6}
_{Check Time}	_{59.55s (± 0.45%)}	_{59.87s (± 0.58%)}	_~	_59.60s	_60.41s	_{p=0.230 n=6}
_{Emit Time}	_{16.17s (± 0.55%)}	_{16.16s (± 0.35%)}	_~	_16.06s	_16.23s	_{p=0.422 n=6}
_{Total Time}	_{89.75s (± 0.34%)}	_{90.08s (± 0.43%)}	_~	_89.71s	_90.71s	_{p=0.065 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{392,583k (± 0.02%)}	_{392,614k (± 0.02%)}	_~	_392,526k	_392,684k	_{p=0.471 n=6}
_{Parse Time}	_{3.06s (± 0.89%)}	_{3.05s (± 0.34%)}	_~	_3.03s	_3.06s	_{p=0.164 n=6}
_{Bind Time}	_{1.39s (± 0.71%)}	_{1.41s (± 0.75%)}	_~	_1.39s	_1.42s	_{p=0.066 n=6}
_{Check Time}	_{13.93s (± 0.19%)}	_{13.97s (± 0.47%)}	_~	_13.91s	_14.07s	_{p=0.374 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{18.38s (± 0.15%)}	_{18.43s (± 0.36%)}	_~	_18.37s	_18.52s	_{p=0.294 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,403k (± 0.01%)}	_{513,414k (± 0.01%)}	_~	_513,359k	_513,535k	_{p=1.000 n=6}
_{Parse Time}	_{3.28s (± 0.42%)}	_{3.29s (± 0.25%)}	_~	_3.28s	_3.30s	_{p=0.121 n=6}
_{Bind Time}	_{1.54s (± 0.26%)}	_{1.54s (± 0.49%)}	_~	_1.53s	_1.55s	_{p=1.000 n=6}
_{Check Time}	_{2.85s (± 0.44%)}	_{2.87s (± 0.65%)}	_~	_2.84s	_2.89s	_{p=0.141 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{7.75s (± 0.24%)}	_{7.77s (± 0.30%)}	_~	_7.74s	_7.80s	_{p=0.168 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-01-27T01:55:31Z

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2024-01-27T02:18:17Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/57197/merge:

Everything looks good!

ahejlsberg · 2024-01-27T16:15:33Z

@typescript-bot test top200

typescript-bot · 2024-01-27T16:15:37Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at f445b4f. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-27T18:26:12Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/57197/merge:

Everything looks good!

DanielRosenwasser · 2024-01-28T10:08:56Z

src/compiler/types.ts

@@ -6125,6 +6125,8 @@ export const enum TypeFlags {
    NonPrimitive    = 1 << 26,  // intrinsic object type
    TemplateLiteral = 1 << 27,  // Template literal type
    StringMapping   = 1 << 28,  // Uppercase/Lowercase type
+    /** @internal */
+    Reserved1       = 1 << 29,  // Used by union/intersection type construction


This is kind of funky - I'd just directly make this IncludesConstrainedTypeVariable.

DanielRosenwasser · 2024-01-28T10:10:41Z

@typescript-bot test this

ahejlsberg added 3 commits January 26, 2024 16:35

Properly handle non-generic string mapping types in unions and inters…

84f2a5e

…ections

Accept new baselines

cf6b384

Add tests

f445b4f

typescript-bot assigned ahejlsberg Jan 27, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jan 27, 2024

ahejlsberg requested a review from DanielRosenwasser January 27, 2024 01:20

DanielRosenwasser reviewed Jan 28, 2024

View reviewed changes

DanielRosenwasser approved these changes Jan 28, 2024

View reviewed changes

DanielRosenwasser merged commit 36f9e9e into main Jan 28, 2024
19 checks passed

DanielRosenwasser deleted the fix57192 branch January 28, 2024 10:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Properly handle non-generic string mapping types in unions and intersections #57197

Properly handle non-generic string mapping types in unions and intersections #57197

ahejlsberg commented Jan 27, 2024

ahejlsberg commented Jan 27, 2024

typescript-bot commented Jan 27, 2024 •

edited

Loading

typescript-bot commented Jan 27, 2024 •

edited

Loading

typescript-bot commented Jan 27, 2024 •

edited

Loading

typescript-bot commented Jan 27, 2024 •

edited

Loading

typescript-bot commented Jan 27, 2024

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Jan 27, 2024

tsc

typescript-bot commented Jan 27, 2024

typescript-bot commented Jan 27, 2024

ahejlsberg commented Jan 27, 2024

typescript-bot commented Jan 27, 2024 •

edited

Loading

typescript-bot commented Jan 27, 2024

DanielRosenwasser Jan 28, 2024

DanielRosenwasser commented Jan 28, 2024

Properly handle non-generic string mapping types in unions and intersections #57197

Properly handle non-generic string mapping types in unions and intersections #57197

Conversation

ahejlsberg commented Jan 27, 2024

ahejlsberg commented Jan 27, 2024

typescript-bot commented Jan 27, 2024 • edited Loading

typescript-bot commented Jan 27, 2024 • edited Loading

typescript-bot commented Jan 27, 2024 • edited Loading

typescript-bot commented Jan 27, 2024 • edited Loading

typescript-bot commented Jan 27, 2024

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Jan 27, 2024

tsc

typescript-bot commented Jan 27, 2024

typescript-bot commented Jan 27, 2024

ahejlsberg commented Jan 27, 2024

typescript-bot commented Jan 27, 2024 • edited Loading

typescript-bot commented Jan 27, 2024

DanielRosenwasser Jan 28, 2024

Choose a reason for hiding this comment

DanielRosenwasser commented Jan 28, 2024

typescript-bot commented Jan 27, 2024 •

edited

Loading

typescript-bot commented Jan 27, 2024 •

edited

Loading

typescript-bot commented Jan 27, 2024 •

edited

Loading

typescript-bot commented Jan 27, 2024 •

edited

Loading

typescript-bot commented Jan 27, 2024 •

edited

Loading