-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly handle non-generic string mapping types in unions and intersections #57197
Conversation
@typescript-bot test top100 |
Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at f445b4f. You can monitor the build here. Update: The results are in! |
Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at f445b4f. You can monitor the build here. Update: The results are in! |
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at f445b4f. You can monitor the build here. Update: The results are in! |
Heya @ahejlsberg, I've started to run the faster perf test suite on this PR at f445b4f. You can monitor the build here. Update: The results are in! |
@ahejlsberg Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
@ahejlsberg Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
Hey @ahejlsberg, the results of running the DT tests are ready. |
@ahejlsberg Here are the results of running the top-repos suite comparing Everything looks good! |
@typescript-bot test top200 |
Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at f445b4f. You can monitor the build here. Update: The results are in! |
@ahejlsberg Here are the results of running the top-repos suite comparing Everything looks good! |
@@ -6125,6 +6125,8 @@ export const enum TypeFlags { | |||
NonPrimitive = 1 << 26, // intrinsic object type | |||
TemplateLiteral = 1 << 27, // Template literal type | |||
StringMapping = 1 << 28, // Uppercase/Lowercase type | |||
/** @internal */ | |||
Reserved1 = 1 << 29, // Used by union/intersection type construction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kind of funky - I'd just directly make this IncludesConstrainedTypeVariable
.
@typescript-bot test this |
Fixes #57192.