Script side implementation for Brace Completion. #7587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs updated Visual Studio components to work.
| @@ -1844,6 +1844,31 @@ namespace FourSlash { | |||
| }); | |||
| } | |||
|
|
|||
| public verifyBraceCompletionAtPostion(negative: boolean, openingBrace: string) { | |||
|
|
|||
| let charCode = 0x28; // '(' | |||
There was a problem hiding this comment.
Use ts.CharacterCodes.
There was a problem hiding this comment.
Just make perform the assignment in the switch to make it more uniform
| case '"': charCode = ts.CharacterCodes.doubleQuote; break; | ||
| case "`": charCode = ts.CharacterCodes.backtick; break; | ||
| case "<": charCode = ts.CharacterCodes.lessThan; break; | ||
| } |
There was a problem hiding this comment.
Consider using a Map<CharacterCodes> and writing
const openBraceMap: Map<CharacterCodes> = {
"{": CharacterCodes.openBrace,
// etc.
}There was a problem hiding this comment.
You should error when the test-writer accidentally gave the wrong input.
| @@ -1844,6 +1844,37 @@ namespace FourSlash { | |||
| }); | |||
| } | |||
|
|
|||
| public verifyBraceCompletionAtPostion(negative: boolean, openingBrace: string) { | |||
|
|
|||
| const openBraceMap: ts.Map<ts.CharacterCodes> = { | |||
There was a problem hiding this comment.
For every call you're going to be creating this, so make this a static property
added 2 commits
March 28, 2016 14:24
|
There is some very bizarre handling here, but I am giving this a 👍 because users can always turn this setting off. Can you open an infrastructure bug on what we've found here? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs updated Visual Studio components to work.
Fixes #1484