ignore dotted files and folders #8484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -716,7 +716,8 @@ namespace ts { | |||
| } | |||
|
|
|||
| // Skip over any minified JavaScript files (ending in ".min.js") | |||
| if (/\.min\.js$/.test(fileName)) { | |||
| // Skip over dotted files and folders as well | |||
| if (/\.min\.js$/.test(fileName) || /[\\/]\.[\w.]/.test(fileName)) { | |||
There was a problem hiding this comment.
consider combining into one regex, and hosting it as a variable declaration outside the function call to avoid creating a new literal every time the function is called.
There was a problem hiding this comment.
also can you add a unit test. something along the lines of https://github.com/Microsoft/TypeScript/blob/master/tests/cases/unittests/convertCompilerOptionsFromJson.ts
|
👍 |
| ["/apath/test.ts", "/apath/.git/a.ts", "/apath/.b.ts", "/apath/..c.ts"], | ||
| ["/apath/test.ts"] | ||
| ) | ||
| }) |
There was a problem hiding this comment.
Shouldn't there be a test "allow dotted files and folders when explicitly requested" ?
There was a problem hiding this comment.
@zhengbli can you add a test for this please.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6861