Support for ES6 Templates #960

DanielRosenwasser · 2014-10-25T00:36:52Z

This pull request is meant to add support for ECMAScript 6 templates and address suggestion #13.

Right now this branch supports:

Both simple and substitution templates for all emit targets
Tagged template parse/emit solely for ES6 (and above) targets.
Syntactic highlighting in the LS for template literals
Completion lists in substitution position.

Things that will be done in a separate commit:

Type checking for tagged template expressions by checking assignability of substitution expressions to respective tag parameters.
Add typings for the "cooked strings" parameter of tags.
Patch up parts of the languages service that don't account for templates.
Better parse errors for places that expect string literals.
Experiment with brace matching on substitution templates.
Experiment with indentation in the language service.

Questions worth asking:

Do we want to accept simple (non-substitution) templates in places we accept string literals (i.e. module names, overloading on string constants, etc.)? On one hand, it would seem more consistent with the rest of our language, but ECMAScript 6 does not accept them in property names.
When indexing with a template literal, should we try to perform a static property lookup?
Are void-typed items allowed to be in substitution position? Are there any restrictions on what can be go in a substitution expression?
Do we want type arguments on a tagged template?

Conflicts: src/compiler/diagnosticInformationMap.generated.ts src/compiler/diagnosticMessages.json

Still need to implement some error recovery and add tests.

These tests still need to be fixed.

…cking.

…eArray.

CyrusNajmabadi · 2014-10-25T00:44:33Z

src/compiler/checker.ts

@@ -5932,6 +5939,12 @@ module ts {
            return getUnionType([type1, type2]);
        }

+        function checkTemplateExpression(node: TemplateExpression): void {
+            forEach((<TemplateExpression>node).templateSpans, templateSpan => {


Explain why this is correct. I believe it's because we rewrite this to string addition, and string addition allows the other side to be of any type. So we don't need to check for things like void types, etc. But it would be good to comment this bit.

JsonFreeman · 2014-10-27T17:48:54Z

"Do we want to accept simple (non-substitution) templates in places we accept string literals (i.e. module names, overloading on string constants, etc.)? On one hand, it would seem more consistent with the rest of our language, but ECMAScript 6 does not accept them in property names."

I would say no. I'm not sure we have a reason to be more lenient than ES6.

DanielRosenwasser · 2014-10-27T21:00:21Z

@JsonFreeman I agree; what about indexing?

JsonFreeman · 2014-10-27T21:09:48Z

I think we can type an index expression with literal, yes.

…havior.

Conflicts: src/compiler/checker.ts src/services/services.ts

Conflicts: src/compiler/diagnosticInformationMap.generated.ts src/compiler/diagnosticMessages.json src/compiler/types.ts src/services/utilities.ts

Support for ES6 Templates

vvakame · 2014-11-10T14:19:59Z

@RyanCavanaugh excuse me. please add es6 label to this issue.
I want to check es6 feature on this url https://github.com/Microsoft/TypeScript/issues?q=label%3AES6

Vadorequest · 2014-11-19T10:41:38Z

I just noticed that this ES6 feature is still a proposal, so why implement it already? Not that it isn't great and useful, just wondering why focusing on things that are still status: Draft on ES6 specs. I guess you have your reasons, just wonder what they are ;)

DanielRosenwasser · 2014-11-20T01:20:42Z

It's actually pretty much nailed down, and it's very unlikely that it will be removed/modified drastically. If anything does change, we'll be very mindful in addressing that. =)

Vadorequest · 2014-11-20T07:05:58Z

Ok, nice then, it's a nice feature btw, looking forward for 1.4. :)

topherfangio · 2014-12-12T02:26:53Z

Hi there, I realize that this is on the Roadmap for 1.4. I'm curious though if we might see it sooner as perhaps an experimental option. My team and I would certainly love to start using this sooner rather than later to clean up our code :-)

Cheers!

DanielRosenwasser · 2014-12-12T07:52:29Z

Hey @topherfangio, glad to hear you're enthusiastic about this feature.

If you're dying to try it out, you can clone our repo and use our release-1.4 branch, but 1.4 is largely on the horizon, just be patient. =)

DanielRosenwasser added 8 commits October 23, 2014 14:57

Rudimentary template support, excluding tagging.

518a5d3

Added tests and baselines for templates.

c0893e1

Merge branch 'letAndConst' into templates

b704f19

Conflicts: src/compiler/diagnosticInformationMap.generated.ts src/compiler/diagnosticMessages.json

Added support for tagged template strings, updated baselines.

e709628

Still need to implement some error recovery and add tests.

Better test coverage for templates in object literals.

0d1a46d

These tests still need to be fixed.

Added tests for tagged templates. Some should fail when we do typeche…

a5b77c6

…cking.

Tests for tagged templates.

799609c

Added syntactic classification for templates; also made 'spans' a Nod…

c03dc10

…eArray.

CyrusNajmabadi reviewed Oct 25, 2014
View reviewed changes

DanielRosenwasser added 7 commits October 28, 2014 18:43

Merge branch 'master' into templates

7fad769

Addressed CR feedback.

4aafe1d

Changed Debug.assert's first parameter to a boolean.

8786d30

Renamed certain functions in the parser to more accurately reflect be…

d45fb77

…havior.

Missed a use when fixing Debug.assert

64097a3

Fixed emit for parenthesized template expressions.

aabfebd

Omit empty template tail literals.

b8535d3

DanielRosenwasser added 3 commits October 28, 2014 18:49

Merge branch 'master' into templates

d522c88

Conflicts: src/compiler/checker.ts src/services/services.ts

Disabled completion list entries in template literal parts for the LS.

ead3c1b

Merge branch 'master' into templates

35cf95c

Conflicts: src/compiler/diagnosticInformationMap.generated.ts src/compiler/diagnosticMessages.json src/compiler/types.ts src/services/utilities.ts

DanielRosenwasser force-pushed the templates branch from 66cb969 to 35cf95c Compare October 29, 2014 02:11

DanielRosenwasser added 3 commits October 30, 2014 15:26

Merge branch 'master' into templates

76c0381

Addressed CR feedback.

63340a0

Merge branch 'master' into templates

3e8978f

DanielRosenwasser added a commit that referenced this pull request Oct 31, 2014

Merge pull request #960 from Microsoft/templates

0a97f5f

Support for ES6 Templates

DanielRosenwasser merged commit 0a97f5f into master Oct 31, 2014

DanielRosenwasser deleted the templates branch October 31, 2014 22:19

danquirk added the ES6 Relates to the ES6 Spec label Nov 10, 2014

DanielRosenwasser mentioned this pull request Nov 21, 2014

Suggestion: string interpolation #13

Closed

DanielRosenwasser mentioned this pull request Jan 3, 2015

Alternative syntax for type assertions to allow XML-like syntax extensions #296

Closed

microsoft locked and limited conversation to collaborators Jun 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for ES6 Templates #960

Support for ES6 Templates #960

DanielRosenwasser commented Oct 25, 2014

CyrusNajmabadi Oct 25, 2014

JsonFreeman commented Oct 27, 2014

DanielRosenwasser commented Oct 27, 2014

JsonFreeman commented Oct 27, 2014

vvakame commented Nov 10, 2014

Vadorequest commented Nov 19, 2014

DanielRosenwasser commented Nov 20, 2014

Vadorequest commented Nov 20, 2014

topherfangio commented Dec 12, 2014

DanielRosenwasser commented Dec 12, 2014

Support for ES6 Templates #960

Support for ES6 Templates #960

Conversation

DanielRosenwasser commented Oct 25, 2014

CyrusNajmabadi Oct 25, 2014

Choose a reason for hiding this comment

JsonFreeman commented Oct 27, 2014

DanielRosenwasser commented Oct 27, 2014

JsonFreeman commented Oct 27, 2014

vvakame commented Nov 10, 2014

Vadorequest commented Nov 19, 2014

DanielRosenwasser commented Nov 20, 2014

Vadorequest commented Nov 20, 2014

topherfangio commented Dec 12, 2014

DanielRosenwasser commented Dec 12, 2014