Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new signing certificate. #1312

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

jrbriggs
Copy link
Member

@jrbriggs jrbriggs commented Jul 2, 2019

The Microsoft certificate is a SHA1 certificate. Move to the hybrid certificate.

@derrickstolee
Copy link
Contributor

/azp run GitHub VFSForGit Mac Functional Tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@jrbriggs
Copy link
Member Author

jrbriggs commented Jul 2, 2019

/azp run GitHub VFSForGit Mac Functional Tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

Copy link
Member

@kewillford kewillford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test this change or are you going to run the signing build to test it?

@wilbaker
Copy link
Member

wilbaker commented Jul 2, 2019

How did you know you should make this change?

@jrbriggs
Copy link
Member Author

jrbriggs commented Jul 3, 2019

How did you test this change or are you going to run the signing build to test it?

@kewillford I'll run a real-sign build once we're into a release branch. I'm reluctant to generate a signed build off a topic branch.

How did you know you should make this change?

@wilbaker Owners of real-signed builds were instructed to move away from the SHA1 certs, and there is a table provided for which cert name to move to. I moved from Microsoft to Microsoft400 as per the table.

@jrbriggs jrbriggs closed this Jul 10, 2019
@jrbriggs jrbriggs reopened this Jul 10, 2019
@jrbriggs jrbriggs merged commit 37816dc into microsoft:master Jul 11, 2019
@jrbriggs jrbriggs deleted the update-certificate branch July 11, 2019 18:38
@derrickstolee derrickstolee added this to the M155 milestone Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants