[Linux] minor POSIX and path case comparison fixups #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this Python test succeeds on Linux as well, we can convert it to POSIXOnly.
The array returned by Directory.GetDirectories() is inconsistently ordered across different OS platforms, so we use a PathComparer to sort the array prior to checking its contents in CheckMainSparseFolder() in the SparseTests functional tests.
wilbaker
reviewed
Oct 1, 2019
GVFS/GVFS.FunctionalTests/Tests/EnlistmentPerFixture/SparseTests.cs
Outdated
Show resolved
Hide resolved
Per advice from wilbaker, just use ShouldContain() on the contents of the array returned by GetDirectories() in CheckMainSparseFolder() instead of sorting it.
chrisd8088
force-pushed
the
posix-and-case-fixups
branch
from
a7efef2
to
d8378f1
Compare
|
/azp run GitHub VFSForGit Mac Functional Tests |
|
No pipelines are associated with this pull request. |
|
/azp run GitHub VFSForGit Mac Functional Tests |
|
No pipelines are associated with this pull request. |
wilbaker
approved these changes
Oct 2, 2019
This was referenced Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert a few recent inadvertent uses of
StringComparison.OrdinalIgnoreCasein file path comparisons to the relevant OS-specificPathComparisonhelpers.The array returned by
Directory.GetDirectories()is inconsistently ordered across different platforms, so we useShouldContainto check the array's contents inCheckMainSparseFolder() in theSparseTestsfunctional tests rather than explicit array indexes.We can also mark one recent new functional test,
RunPythonExecutable(), asPOSIXOnlysince it applies to Linux as well as macOS.