Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sample application for usage of common dialogs in WPF #500

Merged
merged 6 commits into from
Aug 24, 2023
Merged

Added sample application for usage of common dialogs in WPF #500

merged 6 commits into from
Aug 24, 2023

Conversation

dipeshmsft
Copy link
Member

@dipeshmsft dipeshmsft commented Jun 27, 2023 •
edited
Loading

Description

In this PR, we add a sample app demonstrating the use of common dialogs ( OpenFileDialog, SaveFileDialog, OpenFolderDialog ( available in .NET 8 ))

Customer Impact

Allows new WPF users to understand how to use file and folder dialogs easily in WPF.

Risk

None

Note

The application lacks comments and OpenFolderDialog functionality is commented out till it is available in WPF

@dipeshmsft dipeshmsft requested review from singhashish-wpf and a team June 27, 2023 08:47
@miloush
Copy link
Contributor

miloush commented Jul 7, 2023

I have to say this is not the greatest sample app, but I guess it's alright for what this repo already contains.

I would think you either do a showcase-type app, where people can set the properties and invoke the dialog in the UI, or you do something a bit more useful, like a trivial version of Notepad...

@dipeshmsft
Copy link
Member Author

I would think you either do a showcase-type app, where people can set the properties and invoke the dialog in the UI, or you do something a bit more useful, like a trivial version of Notepad...

This is in progress.

@dipeshmsft dipeshmsft merged commit 7530fd2 into main Aug 24, 2023
8 checks passed
@dipeshmsft dipeshmsft deleted the dialogsample branch August 26, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miloush miloush miloush left review comments

@singhashish-wpf singhashish-wpf singhashish-wpf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dipeshmsft @miloush @singhashish-wpf