Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several build failures #93

Merged
merged 10 commits into from
Jul 9, 2019
Merged

Fix several build failures #93

merged 10 commits into from
Jul 9, 2019

Conversation

vatsan-madhavan
Copy link
Member

@vatsan-madhavan vatsan-madhavan commented Jul 9, 2019 •
edited
Loading

Fixes for several build failures.

  • Ensures that WPFSamples.sln and WPFSamples.netcore.sln build cleanly in VS and msbuild
  • Ensures that WPSamples.netcore.sln can build under dotnet.exe with the exception of vcxproj
  • Remove Speech sample from .NET Core solution

@vatsan-madhavan vatsan-madhavan merged commit 317b152 into master Jul 9, 2019
@vatsan-madhavan vatsan-madhavan deleted the dev/vatsan/fix-bld-failures branch July 9, 2019 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpitmathur arpitmathur arpitmathur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vatsan-madhavan @arpitmathur