-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: waitid support #638
Comments
also see golang/go#16628 |
Just an update for the case of Go 1.7 depending on waitid.
|
+1 |
This issue is understood and I will be fixing it as soon as I'm back from my honeymoon. :) |
I've implemented the WNOWAIT flag for the waitid system call. I'd like to verify my change resolves the issue but I'm having trouble getting go 1.7 to build a sample project though, could somebody share some repro steps to see the error in question?
|
Is If it's not in your $GOPATH, it'll need to be. Generally you'd set your $GOPATH to something like If it is inside your $GOPATH, can you paste the contents of the |
@egtann Thanks, that was my issue. I fixed my $GOPATH variable and verified that the go project is compiling and running. My example is a very basic hello world, if somebody has a pet project they'd like me to try to run let me know. |
This would probably be a good test (installing all of Go's tools): |
Hey @benhillis. It seems that this fix was not included for14926. My best, |
@abergs You are correct. The fix is making its way to the release branch. Keep an eye out on the release notes. |
Hope 14936 has it. Downloading right now, will report This really was a surprise for me as a part of heroku toolbelt, which has an autoupdate feature and started using go1.7 @benhillis Congratulations! |
@dreyks Thanks! Please do let me know if this resolves your issue! |
@benhillis Works great for me! Thank you, thank you, thank you. |
indeed it does work. however i now get a BSOD about "attempted execute of nonexecute memory" when connecting to ssh server running in WSL with putty, which is sad, though this is a thing for a separate issue |
@dreyks I'm sorry about that... We have a fix in progress for the bluescreen. |
Well thanks, @benhillis and team. This one is closed now. |
As referenced here:
https://github.com/nodejs/node/blob/be68b68d4863f0d389cc46fdf6f1cbcd1b241d0a/deps/v8/src/d8-posix.cc
The text was updated successfully, but these errors were encountered: