Added button role to clickable divs for accessibility #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrrsharaff
requested review from
dgomezc,
KirillShchetinin,
markAtMicrosoft,
mohannad-abwah,
mvegaca,
sibille,
smmatte,
tejbirsingh and
trevorNgo
as code owners
ngkelly3
approved these changes
Apr 18, 2019
trevorNgo
approved these changes
Apr 18, 2019
SahilTara
approved these changes
Apr 18, 2019
trevorNgo
added a commit
that referenced
this pull request
Apr 22, 2019
* Update Wizard Images and Alt Tags (#367) * Added alt tags to all images in the wizard * Increased the number of retries (#406) * T keng/add types (#385) * add types to reducers * add typescript types to rest of selectors and move containers to proper folder * rename details page * fix merge conflicts off dev * update translations finish settling merge conflicts and move mockvscodeapi to mockdata folder * Added Edit Resource string to button instead of Add Resource if user is editing resource (#396) * Added Edit Resource string if user is editing resource * Save changes instead of edit resource * Removed ID attribute from all svg's (#407) Removed repeated ID attributes from all SVG's * Added page name validation message in summary page (#414) * Added validation message for page names in summary page * Dynamically add package dependencies (#425) * Used dynamic package loading * Changed heading to company 1, 2 etc.. * Crutkas doc adjustments (#430) * Update README.md * Create CONTRIBUTING.md * Update README.md * Create telemetryData.md * Create telemetryData.md * Deleted rogue folder Deleted folder which shouldn't exist * stop api module if sync failed (#436) * add chmod to core engine before attempting engine sync (#437) * add chmod to core engine before attempting engine sync * move to apimodule * T keng/apply vscode themes (#428) * add initial styles from vscode * fix styling for leftsidebar save changes on adding a new svg loader * create new svg mapping to specific react components save changes restrict components alignment in centerview change color of close icon on rightsidebar add fills to more icons add fills to sidebar item icons remove code unrelated to PR fix image sizing on rightsidebar add svgs and apply new styling to page svg change dropdownstyles background and fix details page cropping fix cosmos db icon to another style for multiple theme matching remove unused code fix modal theming fix initial modal styling further dropdown style changes add additional link styling add high contrast borders * fix modal theming fix link font size * fix dropdown styling to a thinner border fix placeholder text styles fix spinner and detail color settings fix css import * fix card styling and fix dropdown borders change stroke color of spinner on cosmos db name validation END THEMES COMMIT - fix merge conflicts * fix merge conflicts with dev * Removed commented code and add useful comments (#431) * Linting changes in the React Templates (#444) * Added Eslint rules to React templates * Added trevor to code owners (#464) * add action types (#438) * create action types for wizard content actions * migrate wizard content actions and vscode api actions * create wizard selection action types * migrate selection actions to separate folder resolve conflicts with moving types fix merge conflicts on rebase * move azure actions to a separate folder and add types * create root action type for all actions * add remaining action types * move action types to components * remove edit from summary (#441) * START COMMIT - Remove ability to Edit modals from summary * remove modal openers from review and generate commit to requeue build * requeue build * remove overwriting of azure function names if adding or removing number of functions (#448) * Wizard Label Accessibility (#446) * Added aria-label to all inputs and drop downs * Added translations to internationalizations * ReadMe Updated : "Instruction To Use" Section added (#468) * ReadMe updated : Instruction to use section added * ReadMe Updated : "Instruction To Use" Section added * Instruction To Use updated with Mac command. * Dandua98/functions name validation style fix (#433) * changed name validation for functions to return validation objects instead of errors * refactored functions * removed validation error from function provider * Add separate service status to post-gen modal (#440) * START COMMIT - create a service selection object * separate cosmosdb and azure functions deployment * add logic for detecting if services deployed on post gen modal * begin resetting wizard action architecture * add button to close wizard if generation and deployment completes * add action to reset all wizard state and start over if generation fails * simplify selector logic * set deployed to finished by default if services not selected * START COMMIT - when rightsidebar selection made then licensing and authoring data saved (#442) * update contributing.md (#453) * update contributing.md * Update CONTRIBUTING.md Co-Authored-By: dandua98 <danish@dandua.com> * updated docs * updated intro paragraph for grammar * dandua98/keybord nav (#447) * added keyboard nav to welcome page * added keyboard nav to welcome page * added navigation to welcome page * added keyboard nav for projectType, frameworks, pages and services section added new strings to whitelist * finished keyboard nav * change card backgrounds to sidebar background colors * fix light theme borders on dropdowns * requeue build * fix merge conflicts in translations file * fixed modal keyboard nav bug * Logger (#463) * Added Logger Class to Extension * Master Detail Sample Data (#477) * Updated sample data served to the grid and masterdetail pages * fixed hover on blue for footer (#492) * Disable add button until modal is able to be sent to prevent resizing (#465) * Disable add button until modal is able to be sent to prevent massive resizing * Changed glove cursor to default * Introduce Extension Module VSCodeUI To Reset Pages Prompt in Wizard (#450) * vscodeUIToResetPagesPrompt * Update localized string for prompt * Resolved Bypass Accessibility Issue (#451) * Added main to all pages resolving bypass accessibility issues * Added navigation and complementary landmarks * Added h1 tags for page titles * Updated internationalization files * decrease count of function names when deleting a function (#470) * fixed same name for cosmos and functions bug (#489) * auto-enable locations and numfunctions dropdowns to open upwards (#490) * added links for Web Template Studio and Report an issue to About (#494) * Added button role to clickable divs for accessibility (#493) * add custom input styling to azure functions and cosmos rightsidebar (#496) * T keng/fix rendering keys (#503) * START COMMIT - add keys to service names on rightsidebar component * add keys to summary tile rendering * add keys to postgen modal * add keys to details pages * Rename Mocks folder and updated mocks README (#506) * Removed old mock templates and updated README * Updated folder name for react templates * Minor updates to the README * change css so that it will not change position and size when output path is very long (#504) * Validate function app names (#509) * Added validation for function names * Set default isValidTitle * Fixed bugs and reduced processing for validation * VSCode settings menu (#511) * add settings to load on startup * look at telemetry settings * do not allow azure functions name as a truthy/falsy value to show input field as it will remove the input if the function name is an empty string (#478) * T keng/fix section spacing (#513) * change div wrapping * fix spacing on sidebar and centerview * send function names instead of function name objects (#515) * Sahil tara/angular templates (#517) * Added angular templates along with Kai's Accessibility Fixes * Fixed many UI bugs that resulted from multiple frameworks * Added more in your face progress ui * Fixed small styling issue in master detail (#518) * T trngo/update vs code setting menu (#519) * Fixed settings menu and updated display names * Update description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not change any UI or functionality. This adds "button" role to divs that are treated like buttons so that the screen reader can treat them as buttons and not text.
Closes #124