Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added button role to clickable divs for accessibility #493

Merged
merged 1 commit into from
Apr 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/client/src/components/Details/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ const Details = ({
<div className={styles.container}>
<div className={styles.backContainer}>
<div
role="button"
tabIndex={0}
onClick={handleBackClick}
onKeyDown={keyDownHandler}
Expand Down
1 change: 1 addition & 0 deletions src/client/src/components/SelectableCard/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ const SelectableCard = ({

return (
<div
role="button"
tabIndex={0}
onClick={() => {
onCardClick(cardNumber);
Expand Down
1 change: 1 addition & 0 deletions src/client/src/components/SummaryTile/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ const SummaryTile = ({
>
{isDraggable && <ReorderSVG className={styles.reorder} />}
<div
role="button"
tabIndex={isEditable ? 0 : -1}
className={classnames({
[styles.indent]: withIndent,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ const AzureFunctionsSelection = ({
className={styles.edit}
onClick={openAzureFunctionsModal}
onKeyDown={onEditKeyDownHandler}
role="button"
>
<FormattedMessage
id="azureFunctionsSelection.edit"
Expand Down
1 change: 1 addition & 0 deletions src/client/src/containers/CosmosDBSelection/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ const CosmosDBSelection = ({
<div className={styles.headerContainer}>
<div>{intl.formatMessage(serviceType)}</div>
<div
role="button"
tabIndex={0}
className={styles.edit}
onClick={openCosmosDbModal}
Expand Down
4 changes: 3 additions & 1 deletion src/client/src/containers/Footer/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,9 @@ const mapStateToProps = (state: AppState): IStateProps => ({
isValidNameAndProjectPath: isValidNameAndProjectPathSelector(state)
});

const mapDispatchToProps = (dispatch: ThunkDispatch<AppState,void,RootAction>): IDispatchProps => ({
const mapDispatchToProps = (
dispatch: ThunkDispatch<AppState, void, RootAction>
): IDispatchProps => ({
setRouteVisited: (route: string) => {
dispatch(setVisitedWizardPageAction(route));
},
Expand Down
1 change: 1 addition & 0 deletions src/client/src/containers/Header/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ const Header = (props: Props) => {
<div className={styles.azureProfile}>
<div className={styles.profileName}>{email}</div>
<div
role="button"
className={styles.button}
tabIndex={0}
onClick={signOutClick}
Expand Down
4 changes: 3 additions & 1 deletion src/client/src/containers/ProjectNameAndOutput/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,9 @@ const mapStateToProps = (state: AppState): IStateProps => ({
projectNameValidation: getProjectNameValidation(state)
});

const mapDispatchToProps = (dispatch: Dispatch<RootAction>): IDispatchProps => ({
const mapDispatchToProps = (
dispatch: Dispatch<RootAction>
): IDispatchProps => ({
updateProjectName: (projectName: string) => {
dispatch(updateProjectNameAction(projectName));
},
Expand Down
4 changes: 3 additions & 1 deletion src/client/src/containers/Welcome/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ const Welcome = ({
);
};

const mapDispatchToProps = (dispatch: Dispatch<RootAction>): IDispatchProps => ({
const mapDispatchToProps = (
dispatch: Dispatch<RootAction>
): IDispatchProps => ({
updateProjectName: (projectName: string) => {
dispatch(updateProjectNameAction(projectName));
},
Expand Down