Put AccessControl files into transport package #2751

DefaultRyan · 2022-07-19T21:16:44Z

The runtime support for this feature shipped in 1.1, but the changes to put the winmd and headers in the nuget were missed. This fixes it.

DefaultRyan · 2022-07-19T21:17:41Z

/azp run

azure-pipelines · 2022-07-19T21:17:59Z

Azure Pipelines successfully started running 1 pipeline(s).

jonwis · 2022-07-20T00:03:23Z

Future work - add a sample using the APIs so we'd notice they were missing.

* update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report * Properly ignore cleanup event if it can't be opened. (#2658) If we can't open the cleanup event, ignore it. Fixes ADO#38606299 * WindowsAppRuntimeInstaller.exe fails if newer version present Discussion #2708: [WindowsAppRuntime installation error: The package could not be installed because a higher version of this package is already installed](#2708) >Microsoft.WindowsAppRuntime.1.1_1000.516.2156.0_x64__8wekyb3d8bbwe Package deployment result : 0x80073d06 The package could not be installed because a higher version of this package is already installed. One or more install operations failed. Result: 0x80073d06 That's a bug - it should be OK, not an error. If v1.1.3 is installed and you run the installer for v1.1.2 we call packageManager.AddPackageAsync(...v1.1.2...) which returns 0x80073d06 == `ERROR_INSTALL_PACKAGE_DOWNGRADE` which is technically an error but functionally it's OK. If you build with 1.1.2 we don't require the runtime packages exactly match 1.1.2, but rather that there needs to be a package equal-or-higher than 1.1.2 (i.e. `>=1.1.2` not `==1.1.2`). If 1.1.3 is installed then all is well. Problem is we should be trapping `ERROR_INSTALL_PACKAGE_DOWNGRADE` and treating it as success. That's a bug on our part. https://task.ms/40411617 FYI: servicing-consider-1.1 = https://task.ms/40411679 * XCOPY command should be <COPY> to ensure execution (#2734) * XCOPY command should be XCOPY.EXE to ensure execution * Changed xcopy.exe to <Copy> * Fix typo * Put AccessControl files into transport package (#2751) * Add projection DLL * Put files into nuget package * Remove noexcept from Bootstrapper API so it can be used from C (#2750) * Remove noexcept from Bootstrapper API so it can be used from C * Switch noexcept to macro-style optional support per feedback * Update bug version to 1.1.3 (#2757) * <Copy> vs XCOPY.EXE -- Unbreak WindowsAppSDK-Nuget-Native.C.props Not-Build break 'build\native\WindowsAppSDK-Nuget-Native.C.props(32,13): error MSB4066: The attribute 'SourceFiles' in element is unrecognized.' -- Foundation builds but the aggregator doesn't. I suspect it's because of the command can't go in a , maybe something more complicated with the PostBuildEvent DependsOn a to do the copy...but I can't find any clear docs or net links clearly spelling it out so rather than fiddling while Rome burns I'm switching back to the original xcopy.exe solution to un-break the pipeline. Will follow up with folks to understand why the PR's build didn't pick this up * Updating reference to pick up license installation fix. (#2531) (#2764) Co-authored-by: Ben Kuhn <benkuhn@microsoft.com> Co-authored-by: Hui Chen <hui.chen@live.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabilka@microsoft.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Johan Laanstra <jlaanstra1221@outlook.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: Ryan Shepherd <ryansh@microsoft.com> Co-authored-by: sachintaMSFT <80828309+sachintaMSFT@users.noreply.github.com> Co-authored-by: Ben Kuhn <benkuhn@microsoft.com>

* Use internal nuget feed for develop branch (#2274) * Test push * Test push revert * Merge and Update FrameworkUDK * publish to feed only on scheduled builds (#2571) * Refactor register API (#2557) * Refactor register API * Address comments * Address minor comments * don't need these parameters * Revert "don't need these parameters" This reverts commit 5c76b96. * FI main into develop (#2602) * Create a pipeline to automate FIs from main to develop (#2610) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml * FI develop into WNP_ContentBuilder_Prev1 (#2656) * Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects * Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544) * Updating spec * Adressing comments * More changes Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> * Create a pipeline to automate FIs from main to develop (#2610) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 * Telemetry char/string. AppData DataStore-1.0. * Retrieve the *Main* package's family name for AppData * Add/Remove the test Main package (DataStore) just like we do the test Framework * Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Do a compiler options pass on all binaries contributing to WinAppSDK (#2629) Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4). Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details. Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it. This now standardizes all C++ projects to... * Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`) * Compile (debug): `/Od` * Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy` * Link (debug) `/DEBUG:FULL /INCREMENTAL` * Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF` https://task.ms/39994837 Foundation https://task.ms/39994852 MRTCore * Add standardized (project-wide) C++ compile and link options * Remove ARM support (not supported, but some ARM-conditional fragments weren't removed) * Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3 * Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options * Removed redundant <Optimization> from *vcxproj * Fixed warnings. Removed unnecessary delayload * Fixed some inconsistencies in project settings * Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load * Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors * Corrected some comments. Added the missing LTCG option * Changed LTCG from fast to normal * Updated FavorSizeOrSpeed to Size instead of Speed * Move LinkIncremental=false for Release builds to the top-level project-wide standard * Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently) * Fixed a comment * Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes * Removed options redundant with WindowsAppSDK.Build.Cpp.props * Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256). * Incorporated feedback * Overhaul NuGet versions to include "main" or "develop" (#2636) * Some old MSTest.pfx references were lingering (and now breaking things) (#2638) * Installation with System-Account doesn't work #2546 (#2565) * Installation with System-Account doesn't work #2546 Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640) * Fix the .NET SDK install script. * Remove .NET SDK version from global.json file. * Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline. * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml Co-authored-by: James Parsons <japarson@microsoft.com> Co-authored-by: Darren Hoehna <dhoehna@yahoo.com> Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> * Update Newtonsoft.Json explicit reference in Dev16 projects to work around vulnerability in older versions (#2662) * User/erlangl/fi develop into feature (#2660) * Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects * Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544) * Updating spec * Adressing comments * More changes Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> * Create a pipeline to automate FIs from main to develop (#2610) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 * Telemetry char/string. AppData DataStore-1.0. * Retrieve the *Main* package's family name for AppData * Add/Remove the test Main package (DataStore) just like we do the test Framework * Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Do a compiler options pass on all binaries contributing to WinAppSDK (#2629) Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4). Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details. Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it. This now standardizes all C++ projects to... * Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`) * Compile (debug): `/Od` * Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy` * Link (debug) `/DEBUG:FULL /INCREMENTAL` * Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF` https://task.ms/39994837 Foundation https://task.ms/39994852 MRTCore * Add standardized (project-wide) C++ compile and link options * Remove ARM support (not supported, but some ARM-conditional fragments weren't removed) * Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3 * Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options * Removed redundant <Optimization> from *vcxproj * Fixed warnings. Removed unnecessary delayload * Fixed some inconsistencies in project settings * Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load * Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors * Corrected some comments. Added the missing LTCG option * Changed LTCG from fast to normal * Updated FavorSizeOrSpeed to Size instead of Speed * Move LinkIncremental=false for Release builds to the top-level project-wide standard * Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently) * Fixed a comment * Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes * Removed options redundant with WindowsAppSDK.Build.Cpp.props * Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256). * Incorporated feedback * Overhaul NuGet versions to include "main" or "develop" (#2636) * Some old MSTest.pfx references were lingering (and now breaking things) (#2638) * Installation with System-Account doesn't work #2546 (#2565) * Installation with System-Account doesn't work #2546 Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640) * Fix the .NET SDK install script. * Remove .NET SDK version from global.json file. * Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline. * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml * Update Newtonsoft.Json explicit reference in Dev16 projects to work around vulnerability in older versions (#2662) Co-authored-by: James Parsons <japarson@microsoft.com> Co-authored-by: Darren Hoehna <dhoehna@yahoo.com> Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: Ryan Shepherd <ryansh@microsoft.com> * FI develop into Content Builder feature branch (#2717) * update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report Co-authored-by: Hui Chen <hui.chen@live.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabilka@microsoft.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * FI develop into notification feature branch (#2733) * update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report * Properly ignore cleanup event if it can't be opened. (#2658) If we can't open the cleanup event, ignore it. Fixes ADO#38606299 * WindowsAppRuntimeInstaller.exe fails if newer version present Discussion #2708: [WindowsAppRuntime installation error: The package could not be installed because a higher version of this package is already installed](#2708) >Microsoft.WindowsAppRuntime.1.1_1000.516.2156.0_x64__8wekyb3d8bbwe Package deployment result : 0x80073d06 The package could not be installed because a higher version of this package is already installed. One or more install operations failed. Result: 0x80073d06 That's a bug - it should be OK, not an error. If v1.1.3 is installed and you run the installer for v1.1.2 we call packageManager.AddPackageAsync(...v1.1.2...) which returns 0x80073d06 == `ERROR_INSTALL_PACKAGE_DOWNGRADE` which is technically an error but functionally it's OK. If you build with 1.1.2 we don't require the runtime packages exactly match 1.1.2, but rather that there needs to be a package equal-or-higher than 1.1.2 (i.e. `>=1.1.2` not `==1.1.2`). If 1.1.3 is installed then all is well. Problem is we should be trapping `ERROR_INSTALL_PACKAGE_DOWNGRADE` and treating it as success. That's a bug on our part. https://task.ms/40411617 FYI: servicing-consider-1.1 = https://task.ms/40411679 * XCOPY command should be <COPY> to ensure execution (#2734) * XCOPY command should be XCOPY.EXE to ensure execution * Changed xcopy.exe to <Copy> * Fix typo * Put AccessControl files into transport package (#2751) * Add projection DLL * Put files into nuget package * Remove noexcept from Bootstrapper API so it can be used from C (#2750) * Remove noexcept from Bootstrapper API so it can be used from C * Switch noexcept to macro-style optional support per feedback * Update bug version to 1.1.3 (#2757) * <Copy> vs XCOPY.EXE -- Unbreak WindowsAppSDK-Nuget-Native.C.props Not-Build break 'build\native\WindowsAppSDK-Nuget-Native.C.props(32,13): error MSB4066: The attribute 'SourceFiles' in element is unrecognized.' -- Foundation builds but the aggregator doesn't. I suspect it's because of the command can't go in a , maybe something more complicated with the PostBuildEvent DependsOn a to do the copy...but I can't find any clear docs or net links clearly spelling it out so rather than fiddling while Rome burns I'm switching back to the original xcopy.exe solution to un-break the pipeline. Will follow up with folks to understand why the PR's build didn't pick this up * Updating reference to pick up license installation fix. (#2531) (#2764) Co-authored-by: Ben Kuhn <benkuhn@microsoft.com> Co-authored-by: Hui Chen <hui.chen@live.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabilka@microsoft.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Johan Laanstra <jlaanstra1221@outlook.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: Ryan Shepherd <ryansh@microsoft.com> Co-authored-by: sachintaMSFT <80828309+sachintaMSFT@users.noreply.github.com> Co-authored-by: Ben Kuhn <benkuhn@microsoft.com> * Missed a few patches during previous merge Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Will Thant <kythant@microsoft.com> Co-authored-by: Joshua Larkin <70237359+j0shuams@users.noreply.github.com> Co-authored-by: Rohan Palaniappan <35987549+rohanp-msft@users.noreply.github.com> Co-authored-by: Scott Jones <sjones@microsoft.com> Co-authored-by: sachintaMSFT <80828309+sachintaMSFT@users.noreply.github.com> Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Paul Purifoy <33183370+pmpurifoy@users.noreply.github.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: James Parsons <japarson@microsoft.com> Co-authored-by: Darren Hoehna <dhoehna@yahoo.com> Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com> Co-authored-by: Ryan Shepherd <ryansh@microsoft.com> Co-authored-by: Hui Chen <hui.chen@live.com> Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabilka@microsoft.com> Co-authored-by: Johan Laanstra <jlaanstra1221@outlook.com> Co-authored-by: Ben Kuhn <benkuhn@microsoft.com>

* FI develop into WNP_ContentBuilder_Prev1 (#2656) * Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects * Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544) * Updating spec * Adressing comments * More changes Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> * Create a pipeline to automate FIs from main to develop (#2610) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 * Telemetry char/string. AppData DataStore-1.0. * Retrieve the *Main* package's family name for AppData * Add/Remove the test Main package (DataStore) just like we do the test Framework * Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Do a compiler options pass on all binaries contributing to WinAppSDK (#2629) Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4). Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details. Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it. This now standardizes all C++ projects to... * Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`) * Compile (debug): `/Od` * Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy` * Link (debug) `/DEBUG:FULL /INCREMENTAL` * Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF` https://task.ms/39994837 Foundation https://task.ms/39994852 MRTCore * Add standardized (project-wide) C++ compile and link options * Remove ARM support (not supported, but some ARM-conditional fragments weren't removed) * Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3 * Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options * Removed redundant <Optimization> from *vcxproj * Fixed warnings. Removed unnecessary delayload * Fixed some inconsistencies in project settings * Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load * Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors * Corrected some comments. Added the missing LTCG option * Changed LTCG from fast to normal * Updated FavorSizeOrSpeed to Size instead of Speed * Move LinkIncremental=false for Release builds to the top-level project-wide standard * Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently) * Fixed a comment * Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes * Removed options redundant with WindowsAppSDK.Build.Cpp.props * Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256). * Incorporated feedback * Overhaul NuGet versions to include "main" or "develop" (#2636) * Some old MSTest.pfx references were lingering (and now breaking things) (#2638) * Installation with System-Account doesn't work #2546 (#2565) * Installation with System-Account doesn't work #2546 Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640) * Fix the .NET SDK install script. * Remove .NET SDK version from global.json file. * Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline. * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml Co-authored-by: James Parsons <japarson@microsoft.com> Co-authored-by: Darren Hoehna <dhoehna@yahoo.com> Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> * User/erlangl/fi develop into feature (#2660) * Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects * Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544) * Updating spec * Adressing comments * More changes Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> * Create a pipeline to automate FIs from main to develop (#2610) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 * Telemetry char/string. AppData DataStore-1.0. * Retrieve the *Main* package's family name for AppData * Add/Remove the test Main package (DataStore) just like we do the test Framework * Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Do a compiler options pass on all binaries contributing to WinAppSDK (#2629) Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4). Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details. Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it. This now standardizes all C++ projects to... * Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`) * Compile (debug): `/Od` * Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy` * Link (debug) `/DEBUG:FULL /INCREMENTAL` * Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF` https://task.ms/39994837 Foundation https://task.ms/39994852 MRTCore * Add standardized (project-wide) C++ compile and link options * Remove ARM support (not supported, but some ARM-conditional fragments weren't removed) * Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3 * Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options * Removed redundant <Optimization> from *vcxproj * Fixed warnings. Removed unnecessary delayload * Fixed some inconsistencies in project settings * Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load * Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors * Corrected some comments. Added the missing LTCG option * Changed LTCG from fast to normal * Updated FavorSizeOrSpeed to Size instead of Speed * Move LinkIncremental=false for Release builds to the top-level project-wide standard * Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently) * Fixed a comment * Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes * Removed options redundant with WindowsAppSDK.Build.Cpp.props * Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256). * Incorporated feedback * Overhaul NuGet versions to include "main" or "develop" (#2636) * Some old MSTest.pfx references were lingering (and now breaking things) (#2638) * Installation with System-Account doesn't work #2546 (#2565) * Installation with System-Account doesn't work #2546 Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640) * Fix the .NET SDK install script. * Remove .NET SDK version from global.json file. * Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline. * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml * Update Newtonsoft.Json explicit reference in Dev16 projects to work around vulnerability in older versions (#2662) Co-authored-by: James Parsons <japarson@microsoft.com> Co-authored-by: Darren Hoehna <dhoehna@yahoo.com> Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: Ryan Shepherd <ryansh@microsoft.com> * FI develop into Content Builder feature branch (#2717) * update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report Co-authored-by: Hui Chen <hui.chen@live.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabilka@microsoft.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * FI develop into notification feature branch (#2733) * update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report * Properly ignore cleanup event if it can't be opened. (#2658) If we can't open the cleanup event, ignore it. Fixes ADO#38606299 * WindowsAppRuntimeInstaller.exe fails if newer version present Discussion #2708: [WindowsAppRuntime installation error: The package could not be installed because a higher version of this package is already installed](#2708) >Microsoft.WindowsAppRuntime.1.1_1000.516.2156.0_x64__8wekyb3d8bbwe Package deployment result : 0x80073d06 The package could not be installed because a higher version of this package is already installed. One or more install operations failed. Result: 0x80073d06 That's a bug - it should be OK, not an error. If v1.1.3 is installed and you run the installer for v1.1.2 we call packageManager.AddPackageAsync(...v1.1.2...) which returns 0x80073d06 == `ERROR_INSTALL_PACKAGE_DOWNGRADE` which is technically an error but functionally it's OK. If you build with 1.1.2 we don't require the runtime packages exactly match 1.1.2, but rather that there needs to be a package equal-or-higher than 1.1.2 (i.e. `>=1.1.2` not `==1.1.2`). If 1.1.3 is installed then all is well. Problem is we should be trapping `ERROR_INSTALL_PACKAGE_DOWNGRADE` and treating it as success. That's a bug on our part. https://task.ms/40411617 FYI: servicing-consider-1.1 = https://task.ms/40411679 * XCOPY command should be <COPY> to ensure execution (#2734) * XCOPY command should be XCOPY.EXE to ensure execution * Changed xcopy.exe to <Copy> * Fix typo * Put AccessControl files into transport package (#2751) * Add projection DLL * Put files into nuget package * Remove noexcept from Bootstrapper API so it can be used from C (#2750) * Remove noexcept from Bootstrapper API so it can be used from C * Switch noexcept to macro-style optional support per feedback * Update bug version to 1.1.3 (#2757) * <Copy> vs XCOPY.EXE -- Unbreak WindowsAppSDK-Nuget-Native.C.props Not-Build break 'build\native\WindowsAppSDK-Nuget-Native.C.props(32,13): error MSB4066: The attribute 'SourceFiles' in element is unrecognized.' -- Foundation builds but the aggregator doesn't. I suspect it's because of the command can't go in a , maybe something more complicated with the PostBuildEvent DependsOn a to do the copy...but I can't find any clear docs or net links clearly spelling it out so rather than fiddling while Rome burns I'm switching back to the original xcopy.exe solution to un-break the pipeline. Will follow up with folks to understand why the PR's build didn't pick this up * Updating reference to pick up license installation fix. (#2531) (#2764) Co-authored-by: Ben Kuhn <benkuhn@microsoft.com> Co-authored-by: Hui Chen <hui.chen@live.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabilka@microsoft.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Johan Laanstra <jlaanstra1221@outlook.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: Ryan Shepherd <ryansh@microsoft.com> Co-authored-by: sachintaMSFT <80828309+sachintaMSFT@users.noreply.github.com> Co-authored-by: Ben Kuhn <benkuhn@microsoft.com> * AppNotificationBuilder features (#2786) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes Co-authored-by: eric langlois <email@ericlanglois.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * AppNotificationContent Builder 1.2 spec (#2648) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Update AppNotificationBuilder-spec.md * Update AppNotificationBuilder-spec.md * Update spec example with changes * Rename selectionMenu to ComboBox * Update AppNotificationBuilder-spec.md * Incorporate feedback * Update spec * Address feedback * Update spec * Update AppNotificationBuilder-spec.md * Address some more nits * Update AppNotificationBuilder-spec.md * Rename ButtonColor to AppNotificationButtonStyle * Committing PR renames and fixes * Address more spec comments * Rename AppNotificationContent->AppNotificationBuilder * Update AppNotificationBuilder-spec.md * Add Tag/Group * Update sample Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update AppNotificationBuilder-spec.md * Rename ImageCrop->AppNotificationImageCrop * Fix spec samples * Reduce number of comments in idl * Add Is*Supported functions to limitations * Update Audio loop param to enum Co-authored-by: Alexander Sklar <asklar@microsoft.com> * AppNotificationBuilder - Code Improvements (#2801) * Addressing nits from a previous PR * Uniform naming for tests * Addressing PR feedback * IsWindows... is the standard method for checking Windows version * nit Co-authored-by: Eric Langlois <erlangl@microsoft.com> * AppNotificationContent Builder Core Features - part II (#2760) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes * AddTextBox * AddTextBox with PlaceHolderText and Title * consexpr all the things * code cleanup * AddComboBox * Improving validation for selection items * Input element limit is for textbox and comboBox combined * formating * struct isn't required unless we decide to do extra validation in the future * PR feedback * Check for non-empty IDs Co-authored-by: Paul Purifoy <pmpurifoy@gmail.com> Co-authored-by: Paul Purifoy <33183370+pmpurifoy@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * AppNotificationBuilder - ProgressBar (#2780) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Initial implementation * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Fixing build break * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes * Don't mix binding and value states * Code cleanup * Using printf as it is the norm for the builder * look proper * spacing * Reorder functions in idl to help github track changes properly * Keeping all progressBar tests together * PR feedback Co-authored-by: Paul Purifoy <pmpurifoy@gmail.com> Co-authored-by: Paul Purifoy <33183370+pmpurifoy@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Encoding/Decoding AppNotificationBuilder arguments (#2805) * Encode arguments * Argument encode/decode * Fix merge issues * Add Decode unit test * Use regex_replace instead * Address nits * Simplify encoding * Added XML escape encodings, need to improve Decode efficiency * Implement efficient decode * Update APITests.cpp * Add unit tests and encode all custom strings Co-authored-by: eric langlois <email@ericlanglois.com> Co-authored-by: James Parsons <japarson@microsoft.com> Co-authored-by: Darren Hoehna <dhoehna@yahoo.com> Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: Ryan Shepherd <ryansh@microsoft.com> Co-authored-by: Will Thant <kythant@microsoft.com> Co-authored-by: Hui Chen <hui.chen@live.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabilka@microsoft.com> Co-authored-by: Johan Laanstra <jlaanstra1221@outlook.com> Co-authored-by: sachintaMSFT <80828309+sachintaMSFT@users.noreply.github.com> Co-authored-by: Ben Kuhn <benkuhn@microsoft.com> Co-authored-by: Paul Purifoy <33183370+pmpurifoy@users.noreply.github.com> Co-authored-by: Alexander Sklar <asklar@microsoft.com> Co-authored-by: Paul Purifoy <pmpurifoy@gmail.com>

* FI develop into WNP_ContentBuilder_Prev1 (#2656) * Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects * Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544) * Updating spec * Adressing comments * More changes Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> * Create a pipeline to automate FIs from main to develop (#2610) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 * Telemetry char/string. AppData DataStore-1.0. * Retrieve the *Main* package's family name for AppData * Add/Remove the test Main package (DataStore) just like we do the test Framework * Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Do a compiler options pass on all binaries contributing to WinAppSDK (#2629) Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4). Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details. Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it. This now standardizes all C++ projects to... * Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`) * Compile (debug): `/Od` * Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy` * Link (debug) `/DEBUG:FULL /INCREMENTAL` * Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF` https://task.ms/39994837 Foundation https://task.ms/39994852 MRTCore * Add standardized (project-wide) C++ compile and link options * Remove ARM support (not supported, but some ARM-conditional fragments weren't removed) * Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3 * Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options * Removed redundant <Optimization> from *vcxproj * Fixed warnings. Removed unnecessary delayload * Fixed some inconsistencies in project settings * Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load * Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors * Corrected some comments. Added the missing LTCG option * Changed LTCG from fast to normal * Updated FavorSizeOrSpeed to Size instead of Speed * Move LinkIncremental=false for Release builds to the top-level project-wide standard * Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently) * Fixed a comment * Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes * Removed options redundant with WindowsAppSDK.Build.Cpp.props * Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256). * Incorporated feedback * Overhaul NuGet versions to include "main" or "develop" (#2636) * Some old MSTest.pfx references were lingering (and now breaking things) (#2638) * Installation with System-Account doesn't work #2546 (#2565) * Installation with System-Account doesn't work #2546 Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640) * Fix the .NET SDK install script. * Remove .NET SDK version from global.json file. * Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline. * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml Co-authored-by: James Parsons <japarson@microsoft.com> Co-authored-by: Darren Hoehna <dhoehna@yahoo.com> Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> * User/erlangl/fi develop into feature (#2660) * Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects * Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544) * Updating spec * Adressing comments * More changes Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> * Create a pipeline to automate FIs from main to develop (#2610) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 * Telemetry char/string. AppData DataStore-1.0. * Retrieve the *Main* package's family name for AppData * Add/Remove the test Main package (DataStore) just like we do the test Framework * Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Do a compiler options pass on all binaries contributing to WinAppSDK (#2629) Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4). Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details. Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it. This now standardizes all C++ projects to... * Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`) * Compile (debug): `/Od` * Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy` * Link (debug) `/DEBUG:FULL /INCREMENTAL` * Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF` https://task.ms/39994837 Foundation https://task.ms/39994852 MRTCore * Add standardized (project-wide) C++ compile and link options * Remove ARM support (not supported, but some ARM-conditional fragments weren't removed) * Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3 * Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options * Removed redundant <Optimization> from *vcxproj * Fixed warnings. Removed unnecessary delayload * Fixed some inconsistencies in project settings * Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load * Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors * Corrected some comments. Added the missing LTCG option * Changed LTCG from fast to normal * Updated FavorSizeOrSpeed to Size instead of Speed * Move LinkIncremental=false for Release builds to the top-level project-wide standard * Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently) * Fixed a comment * Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes * Removed options redundant with WindowsAppSDK.Build.Cpp.props * Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256). * Incorporated feedback * Overhaul NuGet versions to include "main" or "develop" (#2636) * Some old MSTest.pfx references were lingering (and now breaking things) (#2638) * Installation with System-Account doesn't work #2546 (#2565) * Installation with System-Account doesn't work #2546 Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640) * Fix the .NET SDK install script. * Remove .NET SDK version from global.json file. * Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline. * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml * Update Newtonsoft.Json explicit reference in Dev16 projects to work around vulnerability in older versions (#2662) Co-authored-by: James Parsons <japarson@microsoft.com> Co-authored-by: Darren Hoehna <dhoehna@yahoo.com> Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: Ryan Shepherd <ryansh@microsoft.com> * FI develop into Content Builder feature branch (#2717) * update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report Co-authored-by: Hui Chen <hui.chen@live.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabilka@microsoft.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * FI develop into notification feature branch (#2733) * update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report * Properly ignore cleanup event if it can't be opened. (#2658) If we can't open the cleanup event, ignore it. Fixes ADO#38606299 * WindowsAppRuntimeInstaller.exe fails if newer version present Discussion #2708: [WindowsAppRuntime installation error: The package could not be installed because a higher version of this package is already installed](#2708) >Microsoft.WindowsAppRuntime.1.1_1000.516.2156.0_x64__8wekyb3d8bbwe Package deployment result : 0x80073d06 The package could not be installed because a higher version of this package is already installed. One or more install operations failed. Result: 0x80073d06 That's a bug - it should be OK, not an error. If v1.1.3 is installed and you run the installer for v1.1.2 we call packageManager.AddPackageAsync(...v1.1.2...) which returns 0x80073d06 == `ERROR_INSTALL_PACKAGE_DOWNGRADE` which is technically an error but functionally it's OK. If you build with 1.1.2 we don't require the runtime packages exactly match 1.1.2, but rather that there needs to be a package equal-or-higher than 1.1.2 (i.e. `>=1.1.2` not `==1.1.2`). If 1.1.3 is installed then all is well. Problem is we should be trapping `ERROR_INSTALL_PACKAGE_DOWNGRADE` and treating it as success. That's a bug on our part. https://task.ms/40411617 FYI: servicing-consider-1.1 = https://task.ms/40411679 * XCOPY command should be <COPY> to ensure execution (#2734) * XCOPY command should be XCOPY.EXE to ensure execution * Changed xcopy.exe to <Copy> * Fix typo * Put AccessControl files into transport package (#2751) * Add projection DLL * Put files into nuget package * Remove noexcept from Bootstrapper API so it can be used from C (#2750) * Remove noexcept from Bootstrapper API so it can be used from C * Switch noexcept to macro-style optional support per feedback * Update bug version to 1.1.3 (#2757) * <Copy> vs XCOPY.EXE -- Unbreak WindowsAppSDK-Nuget-Native.C.props Not-Build break 'build\native\WindowsAppSDK-Nuget-Native.C.props(32,13): error MSB4066: The attribute 'SourceFiles' in element is unrecognized.' -- Foundation builds but the aggregator doesn't. I suspect it's because of the command can't go in a , maybe something more complicated with the PostBuildEvent DependsOn a to do the copy...but I can't find any clear docs or net links clearly spelling it out so rather than fiddling while Rome burns I'm switching back to the original xcopy.exe solution to un-break the pipeline. Will follow up with folks to understand why the PR's build didn't pick this up * Updating reference to pick up license installation fix. (#2531) (#2764) Co-authored-by: Ben Kuhn <benkuhn@microsoft.com> Co-authored-by: Hui Chen <hui.chen@live.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabilka@microsoft.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Johan Laanstra <jlaanstra1221@outlook.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: Ryan Shepherd <ryansh@microsoft.com> Co-authored-by: sachintaMSFT <80828309+sachintaMSFT@users.noreply.github.com> Co-authored-by: Ben Kuhn <benkuhn@microsoft.com> * AppNotificationBuilder features (#2786) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes Co-authored-by: eric langlois <email@ericlanglois.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * AppNotificationContent Builder 1.2 spec (#2648) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Update AppNotificationBuilder-spec.md * Update AppNotificationBuilder-spec.md * Update spec example with changes * Rename selectionMenu to ComboBox * Update AppNotificationBuilder-spec.md * Incorporate feedback * Update spec * Address feedback * Update spec * Update AppNotificationBuilder-spec.md * Address some more nits * Update AppNotificationBuilder-spec.md * Rename ButtonColor to AppNotificationButtonStyle * Committing PR renames and fixes * Address more spec comments * Rename AppNotificationContent->AppNotificationBuilder * Update AppNotificationBuilder-spec.md * Add Tag/Group * Update sample Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update AppNotificationBuilder-spec.md * Rename ImageCrop->AppNotificationImageCrop * Fix spec samples * Reduce number of comments in idl * Add Is*Supported functions to limitations * Update Audio loop param to enum Co-authored-by: Alexander Sklar <asklar@microsoft.com> * AppNotificationBuilder - Code Improvements (#2801) * Addressing nits from a previous PR * Uniform naming for tests * Addressing PR feedback * IsWindows... is the standard method for checking Windows version * nit Co-authored-by: Eric Langlois <erlangl@microsoft.com> * AppNotificationContent Builder Core Features - part II (#2760) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes * AddTextBox * AddTextBox with PlaceHolderText and Title * consexpr all the things * code cleanup * AddComboBox * Improving validation for selection items * Input element limit is for textbox and comboBox combined * formating * struct isn't required unless we decide to do extra validation in the future * PR feedback * Check for non-empty IDs Co-authored-by: Paul Purifoy <pmpurifoy@gmail.com> Co-authored-by: Paul Purifoy <33183370+pmpurifoy@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Fixed timestamp parsing * AppNotificationBuilder - ProgressBar (#2780) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Initial implementation * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Fixing build break * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes * Don't mix binding and value states * Code cleanup * Using printf as it is the norm for the builder * look proper * spacing * Reorder functions in idl to help github track changes properly * Keeping all progressBar tests together * PR feedback Co-authored-by: Paul Purifoy <pmpurifoy@gmail.com> Co-authored-by: Paul Purifoy <33183370+pmpurifoy@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Address nits * Fix build break in user/purifoypaul/TimestampFix (#2815) * AppNotificationBuilder - ProgressBar (#2780) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Initial implementation * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Fixing build break * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes * Don't mix binding and value states * Code cleanup * Using printf as it is the norm for the builder * look proper * spacing * Reorder functions in idl to help github track changes properly * Keeping all progressBar tests together * PR feedback Co-authored-by: Paul Purifoy <pmpurifoy@gmail.com> Co-authored-by: Paul Purifoy <33183370+pmpurifoy@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * namespace issues Co-authored-by: Paul Purifoy <pmpurifoy@gmail.com> Co-authored-by: Paul Purifoy <33183370+pmpurifoy@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Encoding/Decoding AppNotificationBuilder arguments (#2805) * Encode arguments * Argument encode/decode * Fix merge issues * Add Decode unit test * Use regex_replace instead * Address nits * Simplify encoding * Added XML escape encodings, need to improve Decode efficiency * Implement efficient decode * Update APITests.cpp * Add unit tests and encode all custom strings Co-authored-by: eric langlois <email@ericlanglois.com> Co-authored-by: eric langlois <email@ericlanglois.com> Co-authored-by: James Parsons <japarson@microsoft.com> Co-authored-by: Darren Hoehna <dhoehna@yahoo.com> Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: Ryan Shepherd <ryansh@microsoft.com> Co-authored-by: Will Thant <kythant@microsoft.com> Co-authored-by: Hui Chen <hui.chen@live.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabilka@microsoft.com> Co-authored-by: Johan Laanstra <jlaanstra1221@outlook.com> Co-authored-by: sachintaMSFT <80828309+sachintaMSFT@users.noreply.github.com> Co-authored-by: Ben Kuhn <benkuhn@microsoft.com> Co-authored-by: Alexander Sklar <asklar@microsoft.com>

* FI develop into WNP_ContentBuilder_Prev1 (#2656) * Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects * Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544) * Updating spec * Adressing comments * More changes Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> * Create a pipeline to automate FIs from main to develop (#2610) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 * Telemetry char/string. AppData DataStore-1.0. * Retrieve the *Main* package's family name for AppData * Add/Remove the test Main package (DataStore) just like we do the test Framework * Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Do a compiler options pass on all binaries contributing to WinAppSDK (#2629) Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4). Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details. Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it. This now standardizes all C++ projects to... * Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`) * Compile (debug): `/Od` * Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy` * Link (debug) `/DEBUG:FULL /INCREMENTAL` * Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF` https://task.ms/39994837 Foundation https://task.ms/39994852 MRTCore * Add standardized (project-wide) C++ compile and link options * Remove ARM support (not supported, but some ARM-conditional fragments weren't removed) * Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3 * Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options * Removed redundant <Optimization> from *vcxproj * Fixed warnings. Removed unnecessary delayload * Fixed some inconsistencies in project settings * Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load * Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors * Corrected some comments. Added the missing LTCG option * Changed LTCG from fast to normal * Updated FavorSizeOrSpeed to Size instead of Speed * Move LinkIncremental=false for Release builds to the top-level project-wide standard * Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently) * Fixed a comment * Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes * Removed options redundant with WindowsAppSDK.Build.Cpp.props * Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256). * Incorporated feedback * Overhaul NuGet versions to include "main" or "develop" (#2636) * Some old MSTest.pfx references were lingering (and now breaking things) (#2638) * Installation with System-Account doesn't work #2546 (#2565) * Installation with System-Account doesn't work #2546 Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640) * Fix the .NET SDK install script. * Remove .NET SDK version from global.json file. * Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline. * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml Co-authored-by: James Parsons <japarson@microsoft.com> Co-authored-by: Darren Hoehna <dhoehna@yahoo.com> Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> * User/erlangl/fi develop into feature (#2660) * Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects * Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544) * Updating spec * Adressing comments * More changes Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> * Create a pipeline to automate FIs from main to develop (#2610) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 * Telemetry char/string. AppData DataStore-1.0. * Retrieve the *Main* package's family name for AppData * Add/Remove the test Main package (DataStore) just like we do the test Framework * Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Do a compiler options pass on all binaries contributing to WinAppSDK (#2629) Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4). Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details. Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it. This now standardizes all C++ projects to... * Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`) * Compile (debug): `/Od` * Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy` * Link (debug) `/DEBUG:FULL /INCREMENTAL` * Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF` https://task.ms/39994837 Foundation https://task.ms/39994852 MRTCore * Add standardized (project-wide) C++ compile and link options * Remove ARM support (not supported, but some ARM-conditional fragments weren't removed) * Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3 * Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options * Removed redundant <Optimization> from *vcxproj * Fixed warnings. Removed unnecessary delayload * Fixed some inconsistencies in project settings * Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load * Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors * Corrected some comments. Added the missing LTCG option * Changed LTCG from fast to normal * Updated FavorSizeOrSpeed to Size instead of Speed * Move LinkIncremental=false for Release builds to the top-level project-wide standard * Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently) * Fixed a comment * Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes * Removed options redundant with WindowsAppSDK.Build.Cpp.props * Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256). * Incorporated feedback * Overhaul NuGet versions to include "main" or "develop" (#2636) * Some old MSTest.pfx references were lingering (and now breaking things) (#2638) * Installation with System-Account doesn't work #2546 (#2565) * Installation with System-Account doesn't work #2546 Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640) * Fix the .NET SDK install script. * Remove .NET SDK version from global.json file. * Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline. * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml * Update Newtonsoft.Json explicit reference in Dev16 projects to work around vulnerability in older versions (#2662) Co-authored-by: James Parsons <japarson@microsoft.com> Co-authored-by: Darren Hoehna <dhoehna@yahoo.com> Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: Ryan Shepherd <ryansh@microsoft.com> * FI develop into Content Builder feature branch (#2717) * update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report Co-authored-by: Hui Chen <hui.chen@live.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabilka@microsoft.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * FI develop into notification feature branch (#2733) * update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report * Properly ignore cleanup event if it can't be opened. (#2658) If we can't open the cleanup event, ignore it. Fixes ADO#38606299 * WindowsAppRuntimeInstaller.exe fails if newer version present Discussion #2708: [WindowsAppRuntime installation error: The package could not be installed because a higher version of this package is already installed](#2708) >Microsoft.WindowsAppRuntime.1.1_1000.516.2156.0_x64__8wekyb3d8bbwe Package deployment result : 0x80073d06 The package could not be installed because a higher version of this package is already installed. One or more install operations failed. Result: 0x80073d06 That's a bug - it should be OK, not an error. If v1.1.3 is installed and you run the installer for v1.1.2 we call packageManager.AddPackageAsync(...v1.1.2...) which returns 0x80073d06 == `ERROR_INSTALL_PACKAGE_DOWNGRADE` which is technically an error but functionally it's OK. If you build with 1.1.2 we don't require the runtime packages exactly match 1.1.2, but rather that there needs to be a package equal-or-higher than 1.1.2 (i.e. `>=1.1.2` not `==1.1.2`). If 1.1.3 is installed then all is well. Problem is we should be trapping `ERROR_INSTALL_PACKAGE_DOWNGRADE` and treating it as success. That's a bug on our part. https://task.ms/40411617 FYI: servicing-consider-1.1 = https://task.ms/40411679 * XCOPY command should be <COPY> to ensure execution (#2734) * XCOPY command should be XCOPY.EXE to ensure execution * Changed xcopy.exe to <Copy> * Fix typo * Put AccessControl files into transport package (#2751) * Add projection DLL * Put files into nuget package * Remove noexcept from Bootstrapper API so it can be used from C (#2750) * Remove noexcept from Bootstrapper API so it can be used from C * Switch noexcept to macro-style optional support per feedback * Update bug version to 1.1.3 (#2757) * <Copy> vs XCOPY.EXE -- Unbreak WindowsAppSDK-Nuget-Native.C.props Not-Build break 'build\native\WindowsAppSDK-Nuget-Native.C.props(32,13): error MSB4066: The attribute 'SourceFiles' in element is unrecognized.' -- Foundation builds but the aggregator doesn't. I suspect it's because of the command can't go in a , maybe something more complicated with the PostBuildEvent DependsOn a to do the copy...but I can't find any clear docs or net links clearly spelling it out so rather than fiddling while Rome burns I'm switching back to the original xcopy.exe solution to un-break the pipeline. Will follow up with folks to understand why the PR's build didn't pick this up * Updating reference to pick up license installation fix. (#2531) (#2764) Co-authored-by: Ben Kuhn <benkuhn@microsoft.com> Co-authored-by: Hui Chen <hui.chen@live.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabilka@microsoft.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Johan Laanstra <jlaanstra1221@outlook.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: Ryan Shepherd <ryansh@microsoft.com> Co-authored-by: sachintaMSFT <80828309+sachintaMSFT@users.noreply.github.com> Co-authored-by: Ben Kuhn <benkuhn@microsoft.com> * AppNotificationBuilder features (#2786) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes Co-authored-by: eric langlois <email@ericlanglois.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * AppNotificationContent Builder 1.2 spec (#2648) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Update AppNotificationBuilder-spec.md * Update AppNotificationBuilder-spec.md * Update spec example with changes * Rename selectionMenu to ComboBox * Update AppNotificationBuilder-spec.md * Incorporate feedback * Update spec * Address feedback * Update spec * Update AppNotificationBuilder-spec.md * Address some more nits * Update AppNotificationBuilder-spec.md * Rename ButtonColor to AppNotificationButtonStyle * Committing PR renames and fixes * Address more spec comments * Rename AppNotificationContent->AppNotificationBuilder * Update AppNotificationBuilder-spec.md * Add Tag/Group * Update sample Co-authored-by: Alexander Sklar <asklar@microsoft.com> * Update AppNotificationBuilder-spec.md * Rename ImageCrop->AppNotificationImageCrop * Fix spec samples * Reduce number of comments in idl * Add Is*Supported functions to limitations * Update Audio loop param to enum Co-authored-by: Alexander Sklar <asklar@microsoft.com> * AppNotificationBuilder - Code Improvements (#2801) * Addressing nits from a previous PR * Uniform naming for tests * Addressing PR feedback * IsWindows... is the standard method for checking Windows version * nit Co-authored-by: Eric Langlois <erlangl@microsoft.com> * AppNotificationContent Builder Core Features - part II (#2760) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes * AddTextBox * AddTextBox with PlaceHolderText and Title * consexpr all the things * code cleanup * AddComboBox * Improving validation for selection items * Input element limit is for textbox and comboBox combined * formating * struct isn't required unless we decide to do extra validation in the future * PR feedback * Check for non-empty IDs Co-authored-by: Paul Purifoy <pmpurifoy@gmail.com> Co-authored-by: Paul Purifoy <33183370+pmpurifoy@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * nits * new line to keep github happy * AppNotificationBuilder - ProgressBar (#2780) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Initial implementation * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Fixing build break * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes * Don't mix binding and value states * Code cleanup * Using printf as it is the norm for the builder * look proper * spacing * Reorder functions in idl to help github track changes properly * Keeping all progressBar tests together * PR feedback Co-authored-by: Paul Purifoy <pmpurifoy@gmail.com> Co-authored-by: Paul Purifoy <33183370+pmpurifoy@users.noreply.github.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Nits * Wrong error type * Nits * Spacing * Spacing Co-authored-by: James Parsons <japarson@microsoft.com> Co-authored-by: Darren Hoehna <dhoehna@yahoo.com> Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: Ryan Shepherd <ryansh@microsoft.com> Co-authored-by: Will Thant <kythant@microsoft.com> Co-authored-by: Hui Chen <hui.chen@live.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabilka@microsoft.com> Co-authored-by: Johan Laanstra <jlaanstra1221@outlook.com> Co-authored-by: sachintaMSFT <80828309+sachintaMSFT@users.noreply.github.com> Co-authored-by: Ben Kuhn <benkuhn@microsoft.com> Co-authored-by: Paul Purifoy <33183370+pmpurifoy@users.noreply.github.com> Co-authored-by: Alexander Sklar <asklar@microsoft.com> Co-authored-by: Paul Purifoy <pmpurifoy@gmail.com>

DefaultRyan added 2 commits July 19, 2022 13:43

Add projection DLL

fffb608

Put files into nuget package

03b6015

ghost added the needs-triage label Jul 19, 2022

jonwis approved these changes Jul 20, 2022

View reviewed changes

DefaultRyan merged commit 6c30ec1 into main Jul 20, 2022

DefaultRyan deleted the user/defaultryan/accesscontrol_transport branch July 20, 2022 00:15

bpulliam removed the needs-triage label Apr 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Put AccessControl files into transport package #2751

Put AccessControl files into transport package #2751

DefaultRyan commented Jul 19, 2022

DefaultRyan commented Jul 19, 2022

azure-pipelines bot commented Jul 19, 2022

jonwis commented Jul 20, 2022

Put AccessControl files into transport package #2751

Put AccessControl files into transport package #2751

Conversation

DefaultRyan commented Jul 19, 2022

DefaultRyan commented Jul 19, 2022

azure-pipelines bot commented Jul 19, 2022

jonwis commented Jul 20, 2022