User/erlangl/fixforpaul #2783
Merged
User/erlangl/fixforpaul #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o user/kythant/MainToDevelop
FI from main to develop
FI Main To Develop
* Rename CsWinRT Dependency Variable for Windows SDK * update Version.Details.xml * Under a .NET SDK version check, bring back our (broken) default file inclusion solution for RESW and image files (applies to non-single project MSIX apps only). (#2424) * Under a .NET SDK version check, continue to use our (broken) default file inclusion solution for RESW and image files (applies to non-single project MSIX apps only). * Fixes: use the right version number and use the right property for the version number! Tested. * add end dev library adoption section, link to community call (#2428) * Replace WAR_ prefix with WINDOWSAPPRUNTIME_ prefix (#2430) Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Fix IsSelfContained() to lookup framework packagefamilyname at runtime (#2411) * Added Microsoft::WindowsAppRuntime::VersionInfo::RuntimeInformation as a (partial) runtime-equivalent WindowsAppSDK-VersionInfo.h to workaround the chicken-egg problem where we need to know the versioninfo now but it's nto defined until higher in the build tree (the Aggregator pipeline at the top) * Replaced WindowsAppRuntime_SelfContainedTestInitialize with WindowsAppRuntime_VersionInfo_TestInitialize as we moved the functionality down a level * Removed dead code * Update docs for IsSelfContained * Update test to match SelfContained/VersionInfo::TestInitialize change * Add missing #include * Fix compiler warnings (#2420) * Update WinRT contracts per specs\WinRT\WinRTAPIContracts.md (some contract names didn't match or were absent) * Fixed warnings * Use correct type to avoid warnings on some platform (#2436) Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Trim Resource Id prefix from WINDOWSAPPRUNTIME_ to MSIX_ (#2442) Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * MddBootstrap Telemetry & TraceLogging (#2321) * MddBootStrap API telemetry * Use ThreadLoggingCallback instead of Process wide callback for wil result logging callback * Add safegaurds to call initialize and shutdown activity's StopWithResult only when the activity is running. Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Update WindowsAppSDK-RunHelixTests-Job.yml (#2455) Appended windows.11.amd64.client.open.reunion to helixTargetQueuesOpen and Windows.11.Amd64.client.Reunion to helixTargetQueuesClosed. * UndockedRegFreeWinRT auto-initialization (#2452) * Remove dead code * Add URWF auto-initializer * New URFW files * Connect the dots for URFW auto-initialization support * Added missing file. Fixed compiler warnings * Simplified the C# auto-initializer. Added a comment explaining why it works the way it does * Updated C# auto-initializers to shortcircuit any work if loaded for reflecction (vs execution) * Added missing using * Fix returning a reference to a local variable in GetActivityFlags(); returns a const enum so no reason it can't be by-value and the obvious correctness reason it can't be by-ref * Added build macro WindowsAppSDKCleanIntermediateFiles=<boolean> to scrub intermediate outputs as we build. Defaults to 'true' for build pipeline else undefined and thus not acted on (e.g. dev inner-loop) * Fix prototype for GetIntegrityFlags * Move WindowsAppSDKCleanIntermediateFiles to be a parameter defined by the pipeline, for better inner-loop (for those who want to use the option) * Deploy Main and Singleton in BreakAway process when Deployment API is called from MediumILHigherIL Non-Microsoft publisher package (#2454) Create DeploymentAgent.exe and run it in a breakaway process from Deployment API when the caller is packaged process and has MediumIL/HigherIL integrity level. Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Log Installer events to disk (#2460) * Log Installer events to disk (Application.evtx or Eventvwr.exe -> Windows Logs -> Application) in "WindowsAppRuntime Installer" source. Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Change Singleton package Name to Microsoft.WinAppRuntime.Singleton[-shorttag] * Yet Moar CorpII * Replace WARmain with WARsingleton to point to singleton package * Update Deployment ACIDs in Framework package manifest (#2472) Update Deployment ACIDs in Framework package manifest Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Fix UndockedRegFreeWinRT auto-initializer issues (#2476) * Fix bad filename * No precompiledheaders when compiling the auto-initializer * Copy DeploymentAgent executable to TestFwkPkg (#2467) * Copy DeploymentAgent executable to TestFwkPkg * Make DeploymentAgent a dependency to build Microsoft.Windows.Framework Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Add PushNotificationsLongRunningTask.ProxyStub pdb to symbols dir (#2361) Co-authored-by: Eric Langlois <erlangl@microsoft.com> * Some refinements on the UndockedRegFreeWinRT self-contained and auto-initialization support (#2493) Co-authored-by: Joshua Larkin <70237359+j0shuams@users.noreply.github.com> Co-authored-by: Rohan Palaniappan <35987549+rohanp-msft@users.noreply.github.com> Co-authored-by: Scott Jones <sjones@microsoft.com> Co-authored-by: sachintaMSFT <80828309+sachintaMSFT@users.noreply.github.com> Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: eric langlois <email@ericlanglois.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Paul Purifoy <33183370+pmpurifoy@users.noreply.github.com>
* Refactor register API * Address comments * Address minor comments
This reverts commit 5c76b96.
…0617 User/alexlam/37319832 main 220617
* Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects * Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544) * Updating spec * Adressing comments * More changes Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> * Create a pipeline to automate FIs from main to develop (#2610) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 * Telemetry char/string. AppData DataStore-1.0. * Retrieve the *Main* package's family name for AppData * Add/Remove the test Main package (DataStore) just like we do the test Framework * Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Do a compiler options pass on all binaries contributing to WinAppSDK (#2629) Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4). Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details. Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it. This now standardizes all C++ projects to... * Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`) * Compile (debug): `/Od` * Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy` * Link (debug) `/DEBUG:FULL /INCREMENTAL` * Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF` https://task.ms/39994837 Foundation https://task.ms/39994852 MRTCore * Add standardized (project-wide) C++ compile and link options * Remove ARM support (not supported, but some ARM-conditional fragments weren't removed) * Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3 * Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options * Removed redundant <Optimization> from *vcxproj * Fixed warnings. Removed unnecessary delayload * Fixed some inconsistencies in project settings * Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load * Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors * Corrected some comments. Added the missing LTCG option * Changed LTCG from fast to normal * Updated FavorSizeOrSpeed to Size instead of Speed * Move LinkIncremental=false for Release builds to the top-level project-wide standard * Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently) * Fixed a comment * Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes * Removed options redundant with WindowsAppSDK.Build.Cpp.props * Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256). * Incorporated feedback * Overhaul NuGet versions to include "main" or "develop" (#2636) * Some old MSTest.pfx references were lingering (and now breaking things) (#2638) * Installation with System-Account doesn't work #2546 (#2565) * Installation with System-Account doesn't work #2546 Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640) * Fix the .NET SDK install script. * Remove .NET SDK version from global.json file. * Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline. * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml Co-authored-by: James Parsons <japarson@microsoft.com> Co-authored-by: Darren Hoehna <dhoehna@yahoo.com> Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com>
…round vulnerability in older versions (#2662)
* Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects * Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544) * Updating spec * Adressing comments * More changes Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> * Create a pipeline to automate FIs from main to develop (#2610) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 * Telemetry char/string. AppData DataStore-1.0. * Retrieve the *Main* package's family name for AppData * Add/Remove the test Main package (DataStore) just like we do the test Framework * Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Do a compiler options pass on all binaries contributing to WinAppSDK (#2629) Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4). Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details. Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it. This now standardizes all C++ projects to... * Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`) * Compile (debug): `/Od` * Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy` * Link (debug) `/DEBUG:FULL /INCREMENTAL` * Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF` https://task.ms/39994837 Foundation https://task.ms/39994852 MRTCore * Add standardized (project-wide) C++ compile and link options * Remove ARM support (not supported, but some ARM-conditional fragments weren't removed) * Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3 * Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options * Removed redundant <Optimization> from *vcxproj * Fixed warnings. Removed unnecessary delayload * Fixed some inconsistencies in project settings * Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load * Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors * Corrected some comments. Added the missing LTCG option * Changed LTCG from fast to normal * Updated FavorSizeOrSpeed to Size instead of Speed * Move LinkIncremental=false for Release builds to the top-level project-wide standard * Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently) * Fixed a comment * Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes * Removed options redundant with WindowsAppSDK.Build.Cpp.props * Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256). * Incorporated feedback * Overhaul NuGet versions to include "main" or "develop" (#2636) * Some old MSTest.pfx references were lingering (and now breaking things) (#2638) * Installation with System-Account doesn't work #2546 (#2565) * Installation with System-Account doesn't work #2546 Co-authored-by: Santosh Chintalapati <sachinta@ntdev.microsoft.com> * Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640) * Fix the .NET SDK install script. * Remove .NET SDK version from global.json file. * Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline. * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml * Update Newtonsoft.Json explicit reference in Dev16 projects to work around vulnerability in older versions (#2662) Co-authored-by: James Parsons <japarson@microsoft.com> Co-authored-by: Darren Hoehna <dhoehna@yahoo.com> Co-authored-by: Darren Hoehna <dahoehna@microsoft.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Kyaw Thant <48363984+kythant@users.noreply.github.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: alexlamtest <68841560+alexlamtest@users.noreply.github.com> Co-authored-by: Jeff Genovy <29107334+jefgen@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: Ryan Shepherd <ryansh@microsoft.com>
…into feature/WNP_ContentBuilder_Prev1
* update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report Co-authored-by: Hui Chen <hui.chen@live.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabilka@microsoft.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com>
* update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report * Properly ignore cleanup event if it can't be opened. (#2658) If we can't open the cleanup event, ignore it. Fixes ADO#38606299 * WindowsAppRuntimeInstaller.exe fails if newer version present Discussion #2708: [WindowsAppRuntime installation error: The package could not be installed because a higher version of this package is already installed](#2708) >Microsoft.WindowsAppRuntime.1.1_1000.516.2156.0_x64__8wekyb3d8bbwe Package deployment result : 0x80073d06 The package could not be installed because a higher version of this package is already installed. One or more install operations failed. Result: 0x80073d06 That's a bug - it should be OK, not an error. If v1.1.3 is installed and you run the installer for v1.1.2 we call packageManager.AddPackageAsync(...v1.1.2...) which returns 0x80073d06 == `ERROR_INSTALL_PACKAGE_DOWNGRADE` which is technically an error but functionally it's OK. If you build with 1.1.2 we don't require the runtime packages exactly match 1.1.2, but rather that there needs to be a package equal-or-higher than 1.1.2 (i.e. `>=1.1.2` not `==1.1.2`). If 1.1.3 is installed then all is well. Problem is we should be trapping `ERROR_INSTALL_PACKAGE_DOWNGRADE` and treating it as success. That's a bug on our part. https://task.ms/40411617 FYI: servicing-consider-1.1 = https://task.ms/40411679 * XCOPY command should be <COPY> to ensure execution (#2734) * XCOPY command should be XCOPY.EXE to ensure execution * Changed xcopy.exe to <Copy> * Fix typo * Put AccessControl files into transport package (#2751) * Add projection DLL * Put files into nuget package * Remove noexcept from Bootstrapper API so it can be used from C (#2750) * Remove noexcept from Bootstrapper API so it can be used from C * Switch noexcept to macro-style optional support per feedback * Update bug version to 1.1.3 (#2757) * <Copy> vs XCOPY.EXE -- Unbreak WindowsAppSDK-Nuget-Native.C.props Not-Build break 'build\native\WindowsAppSDK-Nuget-Native.C.props(32,13): error MSB4066: The attribute 'SourceFiles' in element is unrecognized.' -- Foundation builds but the aggregator doesn't. I suspect it's because of the command can't go in a , maybe something more complicated with the PostBuildEvent DependsOn a to do the copy...but I can't find any clear docs or net links clearly spelling it out so rather than fiddling while Rome burns I'm switching back to the original xcopy.exe solution to un-break the pipeline. Will follow up with folks to understand why the PR's build didn't pick this up * Updating reference to pick up license installation fix. (#2531) (#2764) Co-authored-by: Ben Kuhn <benkuhn@microsoft.com> Co-authored-by: Hui Chen <hui.chen@live.com> Co-authored-by: reunion-maestro-bot <reunion-maestro-bot@microsoft.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com> Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> Co-authored-by: Gabby Bilka <gabilka@microsoft.com> Co-authored-by: Gabby Bilka <gabby.bilka@gmail.com> Co-authored-by: Johan Laanstra <jlaanstra1221@outlook.com> Co-authored-by: Howard Kapustein <howardk@microsoft.com> Co-authored-by: Eric Langlois <erlangl@microsoft.com> Co-authored-by: Ryan Shepherd <ryansh@microsoft.com> Co-authored-by: sachintaMSFT <80828309+sachintaMSFT@users.noreply.github.com> Co-authored-by: Ben Kuhn <benkuhn@microsoft.com>
ghost
added
the
|
/azp run TransportPackage-Foundation-PR |
|
No pipelines are associated with this pull request. |
pmpurifoy
approved these changes
Jul 26, 2022
pmpurifoy
added a commit
that referenced
this pull request
Jul 26, 2022
This reverts commit addf73d.
pmpurifoy
added a commit
that referenced
this pull request
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pmpurifoy - This PR would bring your branch in-line with the feature branch. You can either merge it as is or you can just sync your branch with the feature branch. (if you do so, you'll have one conflict in the sln file to manually resolve. You just keep everything.