Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding command line parameters to ai-windows for config path #407

Merged
merged 7 commits into from
Jul 1, 2019
Merged

Adding command line parameters to ai-windows for config path #407

merged 7 commits into from
Jul 1, 2019

Conversation

karanbirsingh
Copy link
Contributor

@karanbirsingh karanbirsingh commented Jun 28, 2019 •
edited
Loading

Describe the change

This is a PR that provides the following command line options to AI-Win:

  • FileToOpen
  • ConfigFolder
  • UserDataFolder
  • AttachToDebugger

These are provided to ConfigurationManager through a FixedConfigSettingsProvider. We should take extra care while reviewing this PR to ensure no breaking changes to configuration paths.

(Please provide an overview of the change in this PR)

PR checklist

  • validation of existing file-opening via command line completed
  • [NA] Does this address an existing issue? If yes, Issue# -
  • [NA] Includes UI changes?
    • [NA] Run the production version of Accessibility Insights for Windows against a version with changes.
    • [NA] Attach any screenshots / GIF's that are applicable.

Note: After the PR has been created, certain checks will be kicked off. All of these checks must pass before a merge.

@karanbirsingh karanbirsingh requested a review from a team as a code owner June 28, 2019 22:56
@karanbirsingh
Copy link
Contributor Author

I forgot to mark this as a draft before clicking create so I have edited the title

@karanbirsingh karanbirsingh changed the title Adding command options that allow for new configuration path to be pa… draft - users can set config path via the command line Jun 28, 2019
@karanbirsingh karanbirsingh added the pr: do not merge This pull request should not be merged. label Jun 28, 2019
@karanbirsingh
Improvements from PR feedback including test run directories, lazy lo…
31d8df4 
…ading of command line options, inclusion in wxs file
DaveTryon
DaveTryon previously approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@DaveTryon DaveTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@karanbirsingh karanbirsingh changed the title draft - users can set config path via the command line Adding command line parameters to ai-windows for config path Jul 1, 2019
@karanbirsingh karanbirsingh removed the pr: do not merge This pull request should not be merged. label Jul 1, 2019
DaveTryon
DaveTryon approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@DaveTryon DaveTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@karanbirsingh karanbirsingh merged commit 8331a9a into microsoft:master Jul 1, 2019
@karanbirsingh karanbirsingh deleted the config branch July 1, 2019 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalkire jalkire jalkire approved these changes

@DaveTryon DaveTryon DaveTryon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karanbirsingh @jalkire @DaveTryon