Fix tree shaking removing code needed for handling ng-content in production builds
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
Angular CLI's Webpack default seems to be pretty aggressive (or there's a bug in one of them), where it removes actual code that should be executed.
This manifested itself already in #8 (fixed by #9).
We need to account for this when writing code in the library - not to write any code that's going to be executed by just loading the scripts, since it may get removed.
Moving the registrations of both
DisguiseandReactContentcomponents to theReactRenderermakes sense, since you're supposed to have one per app, and we're guaranteed that itsconstructorwill get executed.@benfeely Following this, it may be worth re-considering if we want to make the registry an actual Angular Service (i.e.
@Injectable). We discussed this a few months ago but decided to leave it as-is then.