Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix start App Center with startup mode "both" in demo app #2107

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

AnastasiaKubova
Copy link

Things to consider before you submit the PR:

  • Has CHANGELOG.md been updated?
  • ~Are tests passing locally?Z
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you check UI tests on the sample app? They are not executed on CI.
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

When change startup mode to "both", click the crash and send report, the AC portal can't receive the crash report.

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2020

Codecov Report

Merging #2107 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2107   +/-   ##
========================================
  Coverage    91.51%   91.51%           
========================================
  Files          129      129           
  Lines        10147    10147           
========================================
  Hits          9286     9286           
  Misses         861      861           
Flag Coverage Δ
#MacCatalyst 91.38% <ø> (ø)
#iOS 91.80% <ø> (ø)
#macOS 91.45% <ø> (ø)
#tvOS 90.90% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6969ce7...2c7ff5b. Read the comment docs.

@MatkovIvan MatkovIvan merged commit be7097c into develop Jun 29, 2020
@MatkovIvan MatkovIvan deleted the fix/start-ac-with-both-mode branch June 29, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants