Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instructions not to install netfx #95

Merged
merged 1 commit into from May 24, 2019
Merged

Conversation

zarenner
Copy link
Contributor

Installing the netfx plugin is required to support nuget.exe, as the plugin installed by VS is not currently discovered by nuget.exe (only msbuild /restore)

Installing the netfx plugin is required to support nuget.exe, as the plugin installed by VS is not currently discovered by nuget.exe (only msbuild /restore)
@zarenner zarenner requested review from infin8x and satbai May 23, 2019 19:12
3. Copy the `netcore` directory from the extracted archive to `$env:UserProfile\.nuget\plugins`

Note: copying the `netfx` directory is not recommended unless you don't plan to install an edition of Visual Studio (including the Build Tools edition). All Visual Studio editions come with (and automatically update) the `netfx` version of the Credential Provider.
3. Copy the `netcore` (and optionally `netfx` for nuget.exe) directory from the extracted archive to `$env:UserProfile\.nuget\plugins`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, OK. Now I'm remembering something about a good reason for having this warning. @anangaur can you shed some light on why we may have not wanted to install the netfx version of the credprovider into the NuGet plugins folder? I'm vaguely remembering something about that taking precedence of the version that comes with VS and thus never getting updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is definitely a concern (we were just discussing this in the team room), and we need to solve that as part of the longer-term acquisition story. IMO nuget should somehow choose the latest/most preferred or something like that and make it clear in logs which is being used.

If @anangaur has ideas for easily having nuget.exe use the plugin with VS, that would probably be preferable to avoid this issue. But today nuget.exe doesn't "just work" after installing VS and the current doc text implies it does.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I like the current wording - let's run with that.

@zarenner zarenner merged commit 693d010 into master May 24, 2019
@zarenner zarenner deleted the users/zarenner/netfxVS branch May 24, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants