Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove instructions not to install netfx #95

Merged
merged 1 commit into from
May 24, 2019
Merged

Remove instructions not to install netfx #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ If you are using `dotnet` or `nuget`, you can use the Azure Artifact Credential

1. Download the latest release of [Microsoft.NuGet.CredentialProvider.zip](https://github.com/Microsoft/artifacts-credprovider/releases)
2. Unzip the file
3. Copy the `netcore` directory from the extracted archive to `$env:UserProfile\.nuget\plugins`

Note: copying the `netfx` directory is not recommended unless you don't plan to install an edition of Visual Studio (including the Build Tools edition). All Visual Studio editions come with (and automatically update) the `netfx` version of the Credential Provider.
3. Copy the `netcore` (and optionally `netfx` for nuget.exe) directory from the extracted archive to `$env:UserProfile\.nuget\plugins`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, OK. Now I'm remembering something about a good reason for having this warning. @anangaur can you shed some light on why we may have not wanted to install the netfx version of the credprovider into the NuGet plugins folder? I'm vaguely remembering something about that taking precedence of the version that comes with VS and thus never getting updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is definitely a concern (we were just discussing this in the team room), and we need to solve that as part of the longer-term acquisition story. IMO nuget should somehow choose the latest/most preferred or something like that and make it clear in logs which is being used.

If @anangaur has ideas for easily having nuget.exe use the plugin with VS, that would probably be preferable to avoid this issue. But today nuget.exe doesn't "just work" after installing VS and the current doc text implies it does.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I like the current wording - let's run with that.


### Automatic PowerShell installation:

Expand Down