Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websockets demo notebook #2227

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Fix websockets demo notebook #2227

merged 1 commit into from
Apr 1, 2024

Conversation

davorrunje
Copy link
Collaborator

Why are these changes needed?

Notebook demostrating IOStream and IOWebsockets is failing for some users due to failure to create a temporary directory. The code is slightly refactored not to use temporary directories which fixes the problems.

Related issue number

See comments in PR #1551 (e.g. #1551 (comment))

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.83%. Comparing base (989c182) to head (734d263).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2227   +/-   ##
=======================================
  Coverage   37.83%   37.83%           
=======================================
  Files          77       77           
  Lines        7766     7766           
  Branches     1663     1663           
=======================================
  Hits         2938     2938           
  Misses       4579     4579           
  Partials      249      249           
Flag Coverage Δ
unittests 37.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu added this pull request to the merge queue Apr 1, 2024
Merged via the queue into main with commit 3b04210 Apr 1, 2024
27 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants