Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct link to Jupyter Code Executor in code-executors.ipynb #2589

Merged
merged 5 commits into from
May 6, 2024

Conversation

erezak
Copy link
Collaborator

@erezak erezak commented May 4, 2024

The link to the Jupyter code executor was referencing the wrong path.
Current: https://microsoft.github.io/autogen/docs/tutorial/topics/code-execution/jupyter-code-executor
Fixed: https://microsoft.github.io/autogen/docs/topics/code-execution/jupyter-code-executor

Reviewer

@ekzhu

Why are these changes needed?

The link to the Jupyter Code Executor is broken

Related issue number

Closes #2588

Checks

The link to the code executor was referencing the wrong folder.
@erezak erezak marked this pull request as draft May 4, 2024 07:27
@erezak erezak marked this pull request as ready for review May 4, 2024 07:29
Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use absolute path

website/docs/tutorial/code-executors.ipynb Outdated Show resolved Hide resolved
website/docs/tutorial/code-executors.ipynb Outdated Show resolved Hide resolved
erezak and others added 3 commits May 5, 2024 11:08
Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
@erezak erezak requested a review from ekzhu May 5, 2024 08:09
Copy link
Collaborator

@Hk669 Hk669 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

website/docs/tutorial/code-executors.ipynb Outdated Show resolved Hide resolved
website/docs/tutorial/code-executors.ipynb Outdated Show resolved Hide resolved
@ekzhu ekzhu added this pull request to the merge queue May 6, 2024
Merged via the queue into microsoft:main with commit 5a3a8a5 May 6, 2024
18 checks passed
jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
…oft#2589)

* Correct link to Jupyter Code Executor in code-executors.ipynb

The link to the code executor was referencing the wrong folder.

* Update website/docs/tutorial/code-executors.ipynb

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>

* Update website/docs/tutorial/code-executors.ipynb

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>

---------

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue]: Incorrect link to Jupyter Code Executor
3 participants