Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAI Gemini Example for VertexAI Notebook #3290

Merged
merged 19 commits into from
Aug 17, 2024

Conversation

luxzoli
Copy link
Contributor

@luxzoli luxzoli commented Aug 3, 2024

Why are these changes needed?

  • Add example of how to use Gemini with Autogen using the OpenAI client
  • Correct authentication commands with gcloud for environments outside of Google Cloud Shell

Related issue number

Checks

@olaoluwasalami olaoluwasalami self-assigned this Aug 5, 2024
@olaoluwasalami
Copy link
Collaborator

@luxzoli The docs/check(pull_request) is failing, Please can you check this?

@olaoluwasalami
Copy link
Collaborator

@luxzoli for the Service Account, instead of the basic role(editor role), can we look at changing it to predefined roles? We can work on this together

@luxzoli
Copy link
Contributor Author

luxzoli commented Aug 5, 2024

@luxzoli for the Service Account, instead of the basic role(editor role), can we look at changing it to predefined roles? We can work on this together

Good point, and thanks a lot for the support! The roles/aiplatform.user should actually have all the rights which we need for VertexAI. Of course, for things like impersonation additional permissons are needed, but I guess that is out of scope here

@luxzoli
Copy link
Contributor Author

luxzoli commented Aug 5, 2024

@luxzoli The docs/check(pull_request) is failing, Please can you check this?

This should be fixed now :)

@luxzoli
Copy link
Contributor Author

luxzoli commented Aug 11, 2024

@luxzoli for the Service Account, instead of the basic role(editor role), can we look at changing it to predefined roles? We can work on this together

Now the Vertex AI User role is used instead

@qingyun-wu qingyun-wu added this pull request to the merge queue Aug 17, 2024
Merged via the queue into microsoft:main with commit 780523f Aug 17, 2024
19 checks passed
@luxzoli luxzoli deleted the openai-gemini-example branch August 23, 2024 14:36
victordibia pushed a commit that referenced this pull request Aug 28, 2024
* add openai-gemini example

* fix exec numbering

* improve isntructions

* fix br  tag

* mention roles/aiplatform.user and fix markdown reference

* remove mentioning the editor role, and only use the Vertex AI User role

---------

Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants