Skip to content

Commit

Permalink
chore: clean up obsolete yarn resolutions (#856)
Browse files Browse the repository at this point in the history
#### Details

This PR removes several obsolete yarn resolutions (specifically, ones
which were not actually resulting in forcibly upgrading the package they
referenced).

In one instance, this fixed an issue where we were unintentionally
*downgrading* the version of `acorn` being used in one dependency chain.

##### Motivation

Reduce technical debt.

##### Context

n/a

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [x] PR title respects [Conventional
Commits](https://www.conventionalcommits.org) (starts with `fix:`,
`feat:`, etc, and is suitable for user-facing release notes)
- [x] PR contains no breaking changes, **OR** description of both PR
**and final merge commit** starts with `BREAKING CHANGE:`
- [n/a] (if applicable) Addresses issue: #0000
- [n/a] Added relevant unit tests for your changes
- [x] Ran `yarn precheckin`
- [n/a] Verified code coverage for the changes made
  • Loading branch information
dbjorge committed Nov 22, 2022
1 parent cd2f7bb commit 150b427
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
6 changes: 1 addition & 5 deletions package.json
Expand Up @@ -39,11 +39,7 @@
"typescript": "^4.0.2"
},
"resolutions": {
"minimist": "^1.2.3",
"acorn": "^7.1.1",
"kind-of": "^6.0.3",
"ansi-regex": "^5.0.1",
"@npmcli/arborist": ">=2.8.2"
"ansi-regex": "^5.0.1"
},
"scripts": {
"prebuild": "yarn clean",
Expand Down
11 changes: 8 additions & 3 deletions yarn.lock
Expand Up @@ -727,7 +727,7 @@
"@nodelib/fs.scandir" "2.1.4"
fastq "^1.6.0"

"@npmcli/arborist@>=2.8.2", "@npmcli/arborist@^5.0.0", "@npmcli/arborist@^5.0.4":
"@npmcli/arborist@^5.0.0", "@npmcli/arborist@^5.0.4":
version "5.2.1"
resolved "https://registry.yarnpkg.com/@npmcli/arborist/-/arborist-5.2.1.tgz#4f38187cb694946f551a825df17e6efd565b8946"
integrity sha512-DNyTHov3lU7PtCGHABzrPqQOUiBdiYzZ5dLv3D0RD5I9KbmhTLcZI/rv3ddZY0K9vpDE/R+R48b+cU/dUkL0Tw==
Expand Down Expand Up @@ -1367,11 +1367,16 @@ acorn-walk@^7.1.1:
resolved "https://registry.yarnpkg.com/acorn-walk/-/acorn-walk-7.2.0.tgz#0de889a601203909b0fbe07b8938dc21d2e967bc"
integrity sha512-OPdCF6GsMIP+Az+aWfAAOEt2/+iVDKE7oy6lJ098aoe59oAmK76qV6Gw60SbZ8jHuG2wH058GF4pLFbYamYrVA==

acorn@^7.1.1, acorn@^7.4.0, acorn@^8.2.4:
acorn@^7.1.1, acorn@^7.4.0:
version "7.4.1"
resolved "https://registry.yarnpkg.com/acorn/-/acorn-7.4.1.tgz#feaed255973d2e77555b83dbc08851a6c63520fa"
integrity sha512-nQyp0o1/mNdbTO1PO6kHkwSrmgZ0MT/jCCpNiwbUjGoRN4dlBhqJtoQuCnEOKzgTVwg0ZWiCoQy6SxMebQVh8A==

acorn@^8.2.4:
version "8.8.1"
resolved "https://registry.yarnpkg.com/acorn/-/acorn-8.8.1.tgz#0a3f9cbecc4ec3bea6f0a80b66ae8dd2da250b73"
integrity sha512-7zFpHzhnqYKrkYdUjF1HI1bzd0VygEGX8lFk4k5zVMqHEoES+P+7TKI+EvLO9WVMJ8eekdO0aDEK044xTXwPPA==

agent-base@6, agent-base@^6.0.2:
version "6.0.2"
resolved "https://registry.yarnpkg.com/agent-base/-/agent-base-6.0.2.tgz#49fff58577cfee3f37176feab4c22e00f86d7f77"
Expand Down Expand Up @@ -4226,7 +4231,7 @@ minimist-options@4.1.0:
is-plain-obj "^1.1.0"
kind-of "^6.0.3"

minimist@^1.2.0, minimist@^1.2.3, minimist@^1.2.5:
minimist@^1.2.0, minimist@^1.2.5:
version "1.2.6"
resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.6.tgz#8637a5b759ea0d6e98702cfb3a9283323c93af44"
integrity sha512-Jsjnk4bw3YJqYzbdyBiNsPWHPfO++UGG749Cxs6peCu5Xg4nrena6OVxOYxrQTqww0Jmwt+Ref8rggumkTLz9Q==
Expand Down

0 comments on commit 150b427

Please sign in to comment.