Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up obsolete yarn resolutions #856

Merged
merged 1 commit into from Nov 22, 2022

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Nov 7, 2022

Details

This PR removes several obsolete yarn resolutions (specifically, ones which were not actually resulting in forcibly upgrading the package they referenced).

In one instance, this fixed an issue where we were unintentionally downgrading the version of acorn being used in one dependency chain.

Motivation

Reduce technical debt.

Context

n/a

Pull request checklist

  • PR title respects Conventional Commits (starts with fix:, feat:, etc, and is suitable for user-facing release notes)
  • PR contains no breaking changes, OR description of both PR and final merge commit starts with BREAKING CHANGE:
  • [n/a] (if applicable) Addresses issue: #0000
  • [n/a] Added relevant unit tests for your changes
  • Ran yarn precheckin
  • [n/a] Verified code coverage for the changes made

@dbjorge dbjorge requested a review from a team as a code owner November 7, 2022 21:02
@dbjorge dbjorge merged commit 150b427 into microsoft:main Nov 22, 2022
@dbjorge dbjorge deleted the clean-resolutions branch November 22, 2022 20:16
@ada-cat
Copy link
Collaborator

ada-cat commented Jan 31, 2023

🎉 This PR is included in version 2.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants