Limit calculated agent service name to 80 characters #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliobbv
changed the title
| @@ -53,6 +53,18 @@ public void CalculateServiceName(AgentSettings settings, string serviceNamePatte | |||
| } | |||
|
|
|||
| serviceName = StringUtil.Format(serviceNamePattern, accountName, settings.PoolName, settings.AgentName); | |||
|
|
|||
| if (serviceName.Length > 80) | |||
There was a problem hiding this comment.
i assume 80 won't break, only 81+ will break.
There was a problem hiding this comment.
Correct. I tried out with a calculated name with exactly 80 characters, and it works.
| string poolNameSubstring = StringUtil.SubstringPrefix(settings.PoolName, 30); | ||
| string agentNameSubstring = StringUtil.SubstringPrefix(settings.AgentName, 20); | ||
|
|
||
| serviceName = StringUtil.Format(serviceNamePattern, accountNameSubstring, poolNameSubstring, agentNameSubstring); |
There was a problem hiding this comment.
does the serviceNamePattern contains any chars that will contribute to the 80 chars?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.