Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node10 instead of node in runsvc.sh #3267

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Use node10 instead of node in runsvc.sh #3267

merged 1 commit into from
Feb 18, 2021

Conversation

max-zaytsev
Copy link
Contributor

@max-zaytsev max-zaytsev commented Feb 16, 2021 •
edited

Description:

runsvc.sh is trying to call externals/node/bin/node - but in the pipelines-agent only node10 exists

From the logs:

Feb 08 16:09:50 EPDL4402 systemd[1]: Started Azure Pipelines Agent (swisslife.P_VWS.epdl4402_1).
Feb 08 16:09:50 EPDL4402 runsvc.sh[7987]: .path=/home/vwst/.local/bin:/home/vwst/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/ho…otnet/tools
Feb 08 16:09:50 EPDL4402 runsvc.sh[7987]: /apps/vws/ado/agent_1/runsvc.sh: line 16: ./externals/node/bin/node: No such file or directory

So we need to update the script to use node10 instead of node

Attached related issue: #3250

@max-zaytsev max-zaytsev self-assigned this Feb 16, 2021
@max-zaytsev
Copy link
Contributor Author

max-zaytsev commented Feb 16, 2021 •
edited

Tested runsvc.sh with node10 on Ubuntu, CentOS, MacOS

  • Service was started
  • Jobs passed successfully

@max-zaytsev max-zaytsev requested review from mjroghelia and a team February 16, 2021 16:39
@anatolybolshakov anatolybolshakov requested a review from a team February 17, 2021 08:26
@EzzhevNikita
Copy link
Contributor

@max-zaytsev Could you please take a look at test failures for this PR?

@max-zaytsev
Copy link
Contributor Author

@EzzhevNikita Build Linux (ARM) failed with the following error:
##[error]We stopped hearing from agent vsts-core-arm-3...

Passed on retry

@anatolybolshakov anatolybolshakov merged commit 95db487 into master Feb 18, 2021
@max-zaytsev max-zaytsev deleted the users/max-zaytsev/runsvc-node10 branch February 18, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anatolybolshakov anatolybolshakov anatolybolshakov approved these changes

@EzzhevNikita EzzhevNikita EzzhevNikita approved these changes

@mjroghelia mjroghelia Awaiting requested review from mjroghelia

Assignees

@max-zaytsev max-zaytsev

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@max-zaytsev @EzzhevNikita @anatolybolshakov