Specified working directory explicitly for 'docker exec' command - to align behavior with last docker fix #3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 5, 2021 19:10
…ue' of https://github.com/microsoft/azure-pipelines-agent into users/anatolybolshakov/fix_containers_with_root_dir_issue
added 2 commits
May 7, 2021 15:14
EzzhevNikita
approved these changes
May 11, 2021
DaniilShmelev
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a fix in moby repo - previously 'docker exec' worked fine for non-root users with root working directory, but it stopped working after recent update, which led to issues with containers where /root is the current working directory.
See ticket for more info.
PR changes include:
Fix for the issue - explicitly specified working directory for current container user - so commands inside of the container will be executed successfully
Added set up of CurrentUserName for container - so we could pass proper username to working directory (home directory for current container user)
Tested changes manually for container hseeberger/scala-sbt:graalvm-ce-20.0.0-java11_1.4.0_2.13.3)