Fix issue with debug output masking if it contains special symbols #3464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
Currently, the secret masker doesn't mask debug output of the
task.setvariable
command if it contains specials symbols in the variable value (e.g.%
).Example:
Fix description:
It seems the issue is related to the fact that we adding only unescaped command strings to the masker dictionary. To fix this problem we should add to the secret masker dictionary both escaped and unescaped strings.
Changes
CommandStringConvertor
class##vso
commands to the secret masker to resolve the problem with debug output maskingAgent.Sdk.Knob
from theCommand
class as it is not used in the code.Documentation changes required: No
Added unit tests: No
Attached related issue: