-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings instead of exceptions for ConfigurationManager if deployment type has not been determined #3614
Merged
DenisRumyantsev
merged 17 commits into
master
from
users/DenisRumyantsev/fix-deployment-type-determination-exception
Nov 30, 2021
Merged
Warnings instead of exceptions for ConfigurationManager if deployment type has not been determined #3614
DenisRumyantsev
merged 17 commits into
master
from
users/DenisRumyantsev/fix-deployment-type-determination-exception
Nov 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…determination-exception
…determination-exception
Tested this pull request on the TFS 15. Changes work as expected. From now, in the pipeline agent diagnostic logs, during its configuration, the warning is displayed instead of the exception thrown. |
alexander-smolyakov
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
anatolybolshakov
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For some versions (e.g. 15), the Team Foundation Server cannot determine its own deployment type and return it to the agent (was not implemented yet). So the agent should write warnings to the diagnostic logs instead of errors when the deployment type determination is failed. However, if it is failed during the self-update process, the agent still should throw an exception, since:
OnPremises
will be set by default — and no one will know about it until check the agent diagnostic logs (not secure)DISABLE_HASH_VALIDATION=true
ChangeLog:
src/Microsoft.VisualStudio.Services.Agent/Util/ServerUtil.cs —
DeploymentTypeNotDeterminedException
andDeploymentTypeNotRecognizedException
custom exceptions are added;TryIsDeploymentTypeHosted
method implemented. When the agent cannot get the deployment type from the server, this method will write a warning using theTrace
and returnfalse
, which means, that the deployment type is notHosted
.src/Agent.Listener/Configuration/ConfigurationManager.cs — the
TryIsDeploymentTypeHosted
method is used instead of theIsDeploymentTypeHosted
methodsrc/Agent.Listener/SelfUpdater.cs — added more info to the exception message
Related issue