Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for ported logic of handling negative patterns for DownloadBuildArtifacts and DownloadPipelineArtifacts tasks #3665

Merged
merged 3 commits into from
Dec 22, 2021

Conversation

denis-tikhomirov
Copy link
Contributor

@denis-tikhomirov denis-tikhomirov commented Dec 15, 2021

Added tests for ported logic of handling negative patterns for DownloadBuildArtifacts and DownloadPipelineArtifacts tasks.

Checklist:

  • There’s no risky dependency updates

    • Corrected function is used by 2 tasks. And both these tasks work correctly with the changes.
  • Changes has been tested

    • Yes. The changes are tested by 22 cases (2 affected tasks, 11 cases for each task) by build in prepared pipeline. Also test with 7 cases was added in these PR to cover corrected function.
  • Enough test coverage for changes, and current test coverage for task doesn't look poor

    • Yes, test with 7 cases was added in these PR to cover corrected function. Most cases of using the function are covered.
  • We understand how tasks is working, how changes affect task behavior

    • Yes. The changes allow to collect list of files which should be downloaded from artifact. Previously all files are downloaded.
  • There is no breaking changes

    • No breaking changes.
  • There is no any other concerns

    • No concerns. Corrected function is used by 2 tasks. And both these tasks work correctly with the changes.
  • I have not discovered any new uncovered test/use cases

    • Yes, I don't uncovered test/use cases for corrected function.

@denis-tikhomirov denis-tikhomirov requested a review from a team December 15, 2021 12:28
@denis-tikhomirov denis-tikhomirov self-assigned this Dec 15, 2021
@EzzhevNikita EzzhevNikita requested a review from a team December 15, 2021 13:53
@denis-tikhomirov denis-tikhomirov changed the base branch from users/denis-tikhomirov/issue2016 to master December 22, 2021 11:29
@denis-tikhomirov denis-tikhomirov merged commit 0c1261f into master Dec 22, 2021
@denis-tikhomirov denis-tikhomirov changed the title Added tests for ported logic of handling negative patterns for DownloadBuildArtifacts task Added tests for ported logic of handling negative patterns for DownloadBuildArtifacts and DownloadPipelineArtifacts tasks Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants