Adding support of negative patterns for DownloadBuildArtifacts and DownloadPipelineArtifacts tasks in scenarios with using file share

[denis-tikhomirov]

Added support of pre-handling minimatch patterns from azure-pipelines-task-lib (PS version / TS version) to DownloadBuildArtifacts and DownloadPipelineArtifacts tasks in scenarios with using file share.
The logic allows to handle negative minimatch patterns correctly.

Checked cases:

• download all (like **)
• download all (like **) except 1or 2 file (like !**/file.1.nupkg)
• download all (like **) except group of files (like !**/file.*.nupkg)
• download all (like **) except directory (like !**/folder1/**)
• download directory (like **/folder1/**) except 1 file (like !**/folder1/file.1.nupkg)
• download group files (like **/file.*.nupkg) except 1 file (like !**/file.1.nupkg)
• download all (like **) except directory (like !**/folder1/**) but with downloading 1 file from the directory (like !!**/folder1/file.1.nupkg)
• using of whitespaces in start and end of pattern
• using of sharp (#) in pattern
• using of empty pattern
• using of pattern without asterisks (full path to file in artifact)

Checklist:

• There’s no risky dependency updates

  • Corrected function is used by 2 tasks. And both these tasks work correctly with the changes.

• Changes has been tested

  • Yes. The changes are tested by 22 cases (2 affected tasks, 11 cases for each task) by build in prepared pipeline. Also test with 7 cases was added in these PR to cover corrected function.

• Enough test coverage for changes, and current test coverage for task doesn't look poor

  • Yes, test with 7 cases was added in these PR to cover corrected function. Most cases of using the function are covered.

• We understand how tasks is working, how changes affect task behavior

  • Yes. The changes allow to collect list of files which should be downloaded from artifact. Previously all files are downloaded.

• There is no breaking changes

  • No breaking changes.

• There is no any other concerns

  • No concerns. Corrected function is used by 2 tasks. And both these tasks work correctly with the changes.

• I have not discovered any new uncovered test/use cases

  • Yes, I don't uncovered test/use cases for corrected function.

[anatolybolshakov]

LGTM, thanks! Could you please take a look at one last comment also?

[denis-tikhomirov]

Sure. Answered to this.